Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use firmware options on introduction #3900

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Apr 19, 2024

  • Follow up on Add support for using MSP build options #3780
  • Enables testing on current firmware in master
  • We need defines for telemetry for CRSF, GHST and FPORT in firmware or hack them into configurator
  • Add missing telemetry option in case of CRSF, GHST or FPORT
  • Uses firmware options introduced in 4.5.0-4RC4 firmware and beyond
  • Add backwards compatibility using cloud API for earlier 4.5 builds

@haslinghuis haslinghuis self-assigned this Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit fc5ee00
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/662436ceb7583f0008cd5b14
😎 Deploy Preview https://deploy-preview-3900--origin-betaflight-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

@nerdCopter
Copy link
Member

  • so this will use cloud API for 1.45 and MSP for 1.46+, correct?
  • then we still need additional MSP items (options) to fill in the gaps, correct?

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

sonarcloud bot commented Apr 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis changed the title Use firmware options Use firmware options on introduction Apr 20, 2024
@blckmn
Copy link
Member

blckmn commented Apr 20, 2024

I'm not sure about the telemetry issue. Not liking the hardcoded logic for those.

@haslinghuis haslinghuis merged commit 37fada1 into betaflight:master Apr 20, 2024
12 checks passed
@haslinghuis haslinghuis deleted the use-firmware-options branch April 20, 2024 23:39
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
* Use firmware options

* Enable telemetry for CRSF, GHST and FPORT

* Add supported date

* Only add telemetry when not included in firmware

* Reduce brain overload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

None yet

3 participants