Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dshot commands causing motors to spin (when BDIR=OFF) #11424

Closed
limonspb opened this issue Feb 20, 2022 · 1 comment
Closed

Dshot commands causing motors to spin (when BDIR=OFF) #11424

limonspb opened this issue Feb 20, 2022 · 1 comment
Assignees
Labels
BUG Bugs are excluded from automatically being marked as stale

Comments

@limonspb
Copy link
Member

limonspb commented Feb 20, 2022

Describe the bug

The bug has multiple symptoms.
All of them are reproducible at least on F7 (mine FOXEER F722) when bidirectional dshot is OFF.
Git bisect showed that the issue was introduced here:
#11011

Dshot commands (for example changing motor direction from motor direction dialog) cause all motors to spin for a split second.

To Reproduce

  1. Take props off
  2. Flash RC2/RC3 with full chip erase
  3. Apply custom defaults
  4. Set motor protocol dshot 150, 300, 600 (leave bidir OFF)
  5. Save
  6. Plug the battery
  7. Open CLI
  8. type "dshotprog 0 7", hit enter
  9. All motors except motor 1 will spin for a split second

Command "dshotprog 0 7" means
send DSHOT_CMD_SPIN_DIRECTION_1 command to motor 1
Any command from 0 to 49 causes other motors to spin.

Another way to reproduce:

  1. Take props off
  2. Flash RC2/RC3 with full chip erase
  3. Apply custom defaults
  4. Set motor protocol dshot 150, 300, 600 (leave bidir OFF)
  5. Save
  6. Plug the battery
  7. Open motor direction dialog
  8. Select not wizard, but "individually"
  9. Select motor 1
  10. Try to change it's direction
  11. All motors will spin for a split second

Expected behavior

Motors should not spin. Motor 0 direction should become
DSHOT_CMD_SPIN_DIRECTION_1

Flight controller configuration

# diff

# version
# Betaflight / STM32F7X2 (S7X2) 4.3.0 Feb 13 2022 / 23:36:19 (7b4415f06) MSP API: 1.44
# config: manufacturer_id: FOXE, board_name: FOXEERF722V2, version: baa1d34a, date: 2021-08-16T07:35:36Z

# start the command batch
batch start

board_name FOXEERF722V2
manufacturer_id FOXE

# master
set motor_pwm_protocol = DSHOT150
set pid_process_denom = 2
set gyro_1_align_yaw = 2700

profile 0

rateprofile 0

# end the command batch
batch end

Flight controller

FOXEERF722

Other components

does not matter

How are the different components wired up

does not matter

Add any other context about the problem that you think might be relevant here

Git bisect showed that the issue was introduced here:
#11011

f6190e2f1ab3d6d51c4268b6fe707682e7bf547b is the first bad commit
commit f6190e2f1ab3d6d51c4268b6fe707682e7bf547b
Author: Steve Evans
Date:   Fri Dec 17 11:16:26 2021 +0000
    Use bitbanged DSHOT by default if dshot_bitbang = AUTO unless F4
@limonspb limonspb added the Template: Bug Set by auto_close_issue. label Feb 20, 2022
@McGiverGim McGiverGim added the BUG Bugs are excluded from automatically being marked as stale label Feb 20, 2022
@SteveCEvans SteveCEvans self-assigned this Mar 29, 2022
@haslinghuis haslinghuis removed the Template: Bug Set by auto_close_issue. label Apr 2, 2022
@haslinghuis haslinghuis added this to Bug Tracker in Finalizing Firmware 4.3 Release via automation Apr 15, 2022
@haslinghuis
Copy link
Member

@limonspb is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Bugs are excluded from automatically being marked as stale
Projects
None yet
Development

No branches or pull requests

4 participants