Visual beeper not flashing in OSD during ACC Trim in BF 4.3 #11438
Comments
|
The issue with the missing beeps was caused by there being a beep associated with each write to FLASH. As we only write once throttle is lowered, that was lost. Beeps have been resurrected for each trim adjustment. There is thus a slight change in beep behaviour because there will now be a beep per adjustment, and a further beep when the setting are written to FLASH, so an extra beep at the end. I believe this to be reasonable. Fixed in #11380 |
|
Hi @SteveCEvans, no it don't work I've tested today with the latest Development Master build no.2648. For both setups my test observations are the same:
|
|
Hi @SteveCEvans ok after installation BF build no. 2653
|
haslinghuis
added
BUG
haslinghuis
added this to Bug Tracker
in Finalizing Firmware 4.3 Release
via automation
|
@SteveCEvans after installation BF build no. 2662 sill I facing the same issues : I have two setups, one based on Ghost RC Link with STM32F745 (KakuteF7) target and one with ELRS RC Link together with BETAFPVF4SX1280 (ELRS SPI receiver on board) tagret. for ELRS Setup ACC trim rol and ich adjustments made via OSD are saved in FC is OK minor issue is that not always visual beeper is persented in OSD during adjustments |
|
for the BF 4.3 RC4 the same status as above |
|
Please test #11509 Problems reported after: |
|
I just tested with crossfire and ghost and it works. I don't have a beeper or OSD so I can't comment on that. |
|
@haslinghuis yes I confirm Acc calibration and trims works, the only issue is that Visual Beeper is not properly displayed in OSD, most of the time is not displayed at all :) |
|
I tested on an F722 and found that with stick-banging I can change the acc trim, the LED flashes, but the 'visual beeper' does not 'flash' in the OSD at the same time. |
ctzsnooze
changed the title
ctzsnooze
changed the title
|
The issue could be that showVisualBeeper is both set and reset before it's rendered. Lines 1207 to 1209 in 21c8d67 |
|
At the slow rate the OSD task is running at there's no guarantee that we will catch the case where isBeeperOn() == true. |
|
@Martivip Could you try this, please? |
@klutvott123 no still no visual beeper in OSD |
@klutvott123 precisely speaking sometimes it has been rendered but really rarely, most of the time not at all |
|
@Martivip Thanks for testing. We'll have to look into this. It's a bit hard to test as I don't have fpv equipment so I can't actually see the OSD |
|
All right, I think this should work. It uses a latching approach. This lets the beeper set @Martivip Could you try it, pelase? |
@klutvott123 Hi Ok it works, but sometimes when I applying ie. one step of ACC trim (direction it doesn't matter), instead of one blink "****" it blinks randomly couple of times two or three. It looks like visual beeper is rendered randomly twice on time to time. |
|
Is this after bringing throttle back to zero? |
|
No just after Acc trim command before throttle low |
|
when I applying Acc trim command (only one step) sometimes Visual beeper is randomly rendered twice and yes I know that throttle low will trigger visual beeper once again :) |
|
In general this one extra visual beeper render can mislead the operator that he made an increment by two steps instead of one. We need to keep in mind that visual beeper is mostly used without real beeper and that's why the visual beeper should be rendered only once per one increment step :) |
|
@Martivip I agree, the extra beep is not desired behaviour. I made some changes that hopefully will work Thanks for helping testing this. Much appreciated. I really need to get some equipment so I can test this kind of stuff myself Edit: Sorry, I uploaded the wrong binary. Updated with the correct one. |
@klutvott123 Hi ok it works as it should right now, perfect ! one more thing, not related to this bug but maybe you can make a quick look, I'm noticed that one Acc Trim increment (one beep real or visual beeper) is 2 value increments from the configurator perspective |
|
PR to fix this is up #11538 @Martivip Looks like the steps of two is hardcoded. Changes would have to be made to firmware and configurator. We'll have to investigate why it's like this before doing anything. Because this is not a bug, changing it would have to wait until BF 4.4. But I agree, it seems a little strange. betaflight/src/main/fc/rc_controls.c Lines 317 to 334 in 954b737 |
|
@klutvott123 Thank you very much for taking your time for this visual beeper issue :) |
@klutvott123 are you sure that steps of two are also hardcoded in configurator ? I'm asking because in configurator we are able to perform increments by one step not two |
|
Just checked and your right. It's just when doing the adjustment with stick commands |
@klutvott123 so I'm not pushing :) if you find some spare time then maybe you will be able to create quick PR for that |
|
I can do it, but it will still be for 4.4 🙂 |
|
Issue will be closed automatically upon merging the fixing PR. |
please do, but I don't understand why it must wait for 4.4 😑, this is not a new feature this is discrepancy removal between firmware and configurator 😄 that has been found. |
|
@Martivip please open a new issue report for the remaining issue so we can assign it as the original issue is now closed it won't get much attention. |
@haslinghuis Done, Thank You |
Describe the bug
BF has possibility to Trim ACC via OSD stick commands, this has been broken somewhere during the BF 4.3 implementation.
Right now with BF4.3 RC3 and STM32F745 (KakuteF7) target when I try to trim
ACC Pitch or Roll this change is not effective and is not saved in FC, configurator displays "zero" values on both axis
Also the Visual Beeper and Beep sound during the applying changes is not always present and with Timing AAC Forward is not present at all.
With target BETAFPVF4SX1280 (ELRS SPI receiver on board) due to changes in this PR #11380 the Trim Commands via OSD are effective due to huge @SteveCEvans contribution (setting are stored at Throttle Low now). But but it needs few improvements, user need to have control of how many increments he doing for pitch or roll trims, I have enabled visual beeper ***** and I don't see this visual beeper in my OSD during the changes, it should blink once per 1 step on pitch or roll increments and should blink on 1s (or maybe 0,5s) intervals this allow the user to have control during the changes.
Generally as I've mention this functionality has been present in BF 4.2.9 and has been lost during the BF 4.3 Implementation
To Reproduce
Try to adjust, Trim ACC via OSD stick commands
Expected behavior
ACC trim commands should work as it has been implemented in BF 4.2.9
Flight controller configuration
F745 Target
BETAFPVF4SX1280 target
Flight controller
HolyBro KakuteF7 v1.5
Other components
No response
How are the different components wired up
No response
Add any other context about the problem that you think might be relevant here
No response
The text was updated successfully, but these errors were encountered: