Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CI coverage after removal of legacy targets. #12305

Closed
hydra opened this issue Feb 5, 2023 · 2 comments
Closed

Missing CI coverage after removal of legacy targets. #12305

hydra opened this issue Feb 5, 2023 · 2 comments
Labels
Inactive Automatically detected and labeled, will be closed after another week of inactivity. Template: Feature Request Set by auto_close_issue.

Comments

@hydra
Copy link
Contributor

hydra commented Feb 5, 2023

Is your feature request related to a problem? Please describe

As highlighted by #12298 there is missing CI coverage for some code gating paths.

Prior to the removal of legacy targets in #11884 there was CI compiler coverage for more code gating combinations than exists today.

Describe the solution you'd like

Possible solutions:

  1. compile all unified targets once a day, report compile failures and handle them (no PR integration)
  2. ensure PR's are not merged until all unified targets are built by the CI.
  3. have the CI run code coverage over all the base targets and combine the results and have it highlight any code that is not compiled, and add CI specific targets that use specific combinations of code gating, or use scripts to accomplish this, for example like the ones here support\scripts\build_*.

Describe alternatives you've considered

See above.

Other information

Note that:

  • It's not appropriate to use all code gatings in base targets, such as USE_EXST, USE_QUADSPI.
  • It's not possible to use all code gatings at the same time, such as CONFIG_IN_SD_CARD and CONFIG_IN_RAM. The latter is used when bringing up new MCUs before a persistent config storage subsystem is available (such as flash, sd or external flash).
@hydra hydra added the Template: Feature Request Set by auto_close_issue. label Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@github-actions github-actions bot added the Inactive Automatically detected and labeled, will be closed after another week of inactivity. label Mar 8, 2023
@github-actions
Copy link

Issue closed automatically as inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Inactive Automatically detected and labeled, will be closed after another week of inactivity. Template: Feature Request Set by auto_close_issue.
Projects
None yet
Development

No branches or pull requests

1 participant