Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OSD feature for OSD HD build option #12369

Closed
mituritsyn opened this issue Feb 15, 2023 · 5 comments · Fixed by #12563
Closed

Enable OSD feature for OSD HD build option #12369

mituritsyn opened this issue Feb 15, 2023 · 5 comments · Fixed by #12563
Assignees
Labels
BUG Bugs are excluded from automatically being marked as stale

Comments

@mituritsyn
Copy link
Contributor

Describe the bug

Minor confusing issue:
With OSD SD build option OSD feature will be enabled by default, but with OSD HD only it won't be enabled

To Reproduce

Flash via cloud build with OSD HD only

Expected behavior

OSD feature enabled by default

Support ID

osd hd: 8f29abeb-c891-4e7d-9116-65df20c80148
osd sd: 106e3f30-a857-4c7f-b64e-4a55ddea2f95

Flight controller

matek f405std

Other components

No response

How are the different components wired up (including port information)

No response

Add any other context about the problem that you think might be relevant here

No response

@mituritsyn mituritsyn added the Template: Bug Set by auto_close_issue. label Feb 15, 2023
@haslinghuis
Copy link
Member

diff 106e3f30-a857-4c7f-b64e-4a55ddea2f95 8f29abeb-c891-4e7d-9116-65df20c80148

< OSD: MAX7456 (30 x 13)
< BUILD KEY: dfdcf6b3305513b48622922f4088f684 (4.5.0-zulu)
---
> OSD: NONE (60 x 157)
> BUILD KEY: b4635dbba024181fe1baf0511fc003f7 (4.5.0-zulu)

OSD_HD is missing:

resource OSD_CS 1 B10
feature OSD
set max7456_clock = NOMINAL
set max7456_spi_bus = 2
set max7456_preinit_opu = OFF

@blckmn if OSD_HD is defined without OSD_SD should we set osd_displayport_device = MSP as default and keep enable feature OSD ?

@haslinghuis haslinghuis added BUG Bugs are excluded from automatically being marked as stale and removed Template: Bug Set by auto_close_issue. labels Feb 15, 2023
@SteveCEvans SteveCEvans self-assigned this Mar 19, 2023
@SteveCEvans
Copy link
Member

If the MSP_SET_OSD_CANVAS command is received and USE_OSD_HD is defined then set osd_displayport_device = MSP will be performed automatically. This requires the VTX to send this command.

@mituritsyn
Copy link
Contributor Author

If the MSP_SET_OSD_CANVAS command is received and USE_OSD_HD is defined then set osd_displayport_device = MSP will be performed automatically. This requires the VTX to send this command.

How should VTX send something before been powered up? Common setting up scenario assumes battery will be plugged after all settings are done.

@SteveCEvans
Copy link
Member

The first time the VTX is powered up these settings are changed and then saved.

@SteveCEvans
Copy link
Member

Apologies. I missed the point of this issue. Please see #12563 for a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Bugs are excluded from automatically being marked as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants