Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target FF_PICOBLX has crazy high PIDs #4486

Closed
Arakon opened this issue Nov 4, 2017 · 8 comments
Closed

Target FF_PICOBLX has crazy high PIDs #4486

Arakon opened this issue Nov 4, 2017 · 8 comments

Comments

@Arakon
Copy link
Contributor

Arakon commented Nov 4, 2017

As defined by config.c, the PIDs for this (pretty average, hardware-wise) F3 board are:

            pidProfile->pid[PID_ROLL].P = 80;
            pidProfile->pid[PID_ROLL].I = 37;
            pidProfile->pid[PID_ROLL].D = 35;
            pidProfile->pid[PID_PITCH].P = 100;
            pidProfile->pid[PID_PITCH].I = 37;
            pidProfile->pid[PID_PITCH].D = 35;
            pidProfile->pid[PID_YAW].P = 180;
            pidProfile->pid[PID_YAW].D = 45;

Rates are also fairly high and not "safe defaults".
This causes issues when using the default values on copters such as the Kingkong Flyegg series, which use this target.
Is there a specific reason for these high PIDs?

@mikeller
Copy link
Member

mikeller commented Nov 4, 2017

@MJ666 should be able to answer this.

@MJ666
Copy link
Contributor

MJ666 commented Nov 5, 2017

This values only getting active for all of the brushed FuriousFPV FC's. This are the two Acrowhoop and the Nuke boards. This boards are used for whoop stye copters. I got this values from FuriousFPV and fly them myself with my two whoops without problems. For an standard
PikoBLX FC this values should not get active and normal BF defaults should be set. If they get activated for some reason the brushed ESC detection is not working as expected. Likely the ESC drags the signal of motor port to ground. This is very unusual and I have not seen this before and i also have a few PikoBLX builds. A while ago I fixed an issue with the timing of the hardware detection of the AlienFlightNG F7. This caused the wrong version was detected. This problem could be related. I can make an build with an longer delay here for testing. https://github.com/betaflight/betaflight/blob/master/src/main/drivers/pwm_esc_detect.c#L46
An value of 4o was needed to work correctly here. If this will not help it may be related to the ESC's used in this build.

@Arakon
Copy link
Contributor Author

Arakon commented Nov 5, 2017

I believe it's the stock ESC/FC stack used in the Kingkong Flyegg copters.
https://www.banggood.com/Kingkong-FLY-EGG-Racing-Drone-Spare-Parts-2-3S-BLheli_S-10A-ESC-p-1172987.html
https://www.gearbest.com/flight-controller/pp_775587.html

Here you can see it defaulting to the high PIDs:
https://youtu.be/NA86jTYjdjA?t=3m24s

This has been reported here:
https://www.rcgroups.com/forums/showthread.php?2915938-King-Kong-fly-egg-100-130mm/page22 post 327 and down.

@MJ666
Copy link
Contributor

MJ666 commented Nov 5, 2017

In the video you can see the PikoBLX board is detecting brushed ESC's this happens wen the motor1 signal is probed and has low potential. This is normally happen with the usual 10K pulldown resistor of the brushed ESC's. I have never seen this happen on brushless ESC's yet and also have a few builds with various brushless ESC (including one with an 10A 4in1 ESC 20x20mm). Attached you can find an test build of the 3.2.2 firmware with an extended delay to see if this is an timing problem as i have seen on the AFNG F7 controllers.

betaflight_3.2.2_FF_PIKOBLX.zip

Otherwise it is an specific issue of the ESC's used for this builds. Normally brushless ESC should have high (inactive) potential at the motor inputs if nothing is connected. during probing the output of the motor signal is not enabled.

@martinbudden
Copy link
Contributor

@MJ666 , can we close this issue?

@MJ666
Copy link
Contributor

MJ666 commented Nov 7, 2017

Have not gotten any feedback from a tester yet. Can not reproduce the issue on my copters here.

@MJ666
Copy link
Contributor

MJ666 commented Nov 13, 2017

Looks to be this specific ESC is behaving special if not powered up and dragging the signal to low. Usualy I have never connected the battery during flashing the FC and have not seen this before. Will do some more testing to see if i can see this beheavior on any of my copters. This problem should affect a few more targets. The easy workaround is to power the ESC an reset settings.

@MJ666
Copy link
Contributor

MJ666 commented Dec 7, 2017

No more information. Looks to be related to the specific ESC. Closing this here.

@MJ666 MJ666 closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants