Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master (Linux) does not see filenames with capital filename extensions #587

Closed
meoso opened this issue Jun 24, 2022 · 3 comments · Fixed by #591
Closed

master (Linux) does not see filenames with capital filename extensions #587

meoso opened this issue Jun 24, 2022 · 3 comments · Fixed by #591

Comments

@meoso
Copy link

meoso commented Jun 24, 2022

Describe the bug

  • master's open-file dialog does not see files with capital letter extensions
  • e.g. BBL, AVI, etc do not list; However bbl, avi do list.
  • Linux 5.10.0-15-amd64 SMP Debian 5.10.120-1 (2022-06-09) x86_64 GNU/Linux (did not test other OS's)
  • PR Bump NW.js and ffpmeg library to 0.62.2 and Node to 16.15.1 #574 does not solve.
  • the code is correctly using the /i ignore case parameter, therefore i suspect NWjs as the problem-source
                isLog = files[i].name.match(/\.(BBL|TXT|CFL|BFL|LOG)$/i),
                isVideo = files[i].name.match(/\.(AVI|MOV|MP4|MPEG)$/i),
                isWorkspaces = files[i].name.match(/\.(JSON)$/i);

image

To Reproduce

on Linux, use 3.6.0, open files

Expected behavior

list compatible files no matter the extension letter-case (lowerCase / capitalCase)

Betaflight Blackbox Explorer version

3.6.0

Add any other context about the problem that you think might be relevant here

No response

@haslinghuis
Copy link
Member

Works on Ubuntu 20.04 LTS

Try

                isLog = files[i].name.toLowerCase().match(/\.(BBL|TXT|CFL|BFL|LOG)$/),
                isVideo = files[i].name.toLowerCase().match(/\.(AVI|MOV|MP4|MPEG)$/),
                isWorkspaces = files[i].name.toLowerCase().match(/\.(JSON)$/);

@meoso
Copy link
Author

meoso commented Jun 25, 2022

Works on Ubuntu 20.04 LTS

Also confirmed Ubuntu 20.04.4 LTS working. My Debian 11 obviously different :( both are XFCE4, fwiw.
My workaround to to select "all files" in the dialog.

@meoso meoso closed this as completed Jun 25, 2022
@meoso
Copy link
Author

meoso commented Jul 19, 2022

findings:

  • NWjs 0.55.0 and prior, works
  • NWjs 0.56.0 though 0.65.1 fails
  • NWjs 0.66.0 and .1 works

Caveat, all the above only tested with node v16.15.1 on Debian 11 only.

edit: corrections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants