Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NWjs and ffmpeg libraries to 0.68.1, Node to 16.17.0 #591

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 19, 2022

Bump early as there is a bug currently not able to open log files with uppercase extensions.

Fixes: #587 (comment)

@blckmn
Copy link
Member

blckmn commented Jul 20, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@meoso
Copy link

meoso commented Aug 31, 2022

Do you want to test this code? Here you have an automated build: Betaflight-Blackbox-Explorer-Linux

Ubuntu 20.04.5 LTS:

  • portable version works 100% (including video-export)
  • .deb package:
$ /opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer 
/opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer: error while loading shared libraries: libnw.so: cannot open shared object file: No such file or directory

Debian 11 (Stable):

  • Portable version works, with exception of video-export. (see below)
  • .deb package: ZST compression problem : can be rebuilt to XY, compression, so i did, but upon install, it has the chmod file-rights incorrectly set, just the same as configurator had during other nwjs stages.
  • Opened issue with gulp-debian fwiw: issue/feature request - compression method (-Zxz) stpettersens/gulp-debian#25
  • used yarn gulp release --linux64 locally on Debian 11, installed package. fails with /opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer: error while loading shared libraries: libnw.so: cannot open shared object file: No such file or directory
  • /opt/betaflight/betaflight-blackbox-explorer/lib/libnw.so does exist; unsure why the error.

Video export on Debian 11:

  • release 0.3.6 & this build fails video-export dialog with this message: [212733:212755:0831/083926.977149:ERROR:select_file_dialog_impl_portal.cc(698)] Portal returned error: org.freedesktop.portal.Error.InvalidArgument: invalid filter: name is empty

@haslinghuis haslinghuis changed the title Bump NWjs and ffmpeg libraries to 0.66.0 Bump NWjs and ffmpeg libraries to 0.67.1 Sep 3, 2022
@haslinghuis
Copy link
Member Author

used yarn gulp release --linux64 locally on Debian 11, installed package. fails with /opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer: error while loading shared libraries: libnw.so: cannot open shared object file: No such file or directory

/opt/betaflight/betaflight-blackbox-explorer/lib/libnw.so does exist; unsure why the error.

Video export on Debian 11:

release 0.3.6 & this build fails video-export dialog with this message: [212733:212755:0831/083926.977149:ERROR:select_file_dialog_impl_portal.cc(698)] Portal returned error: org.freedesktop.portal.Error.InvalidArgument: invalid filter: name is empty

@meoso please check on nwjs 0.67.1 now ffmpeg libraries are available.

@meoso
Copy link

meoso commented Sep 6, 2022

14f8bb9

Ubuntu 20.04.5 LTS

  • Portable works including video-export with only the following: [128080:128089:0906/080226.179012:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
  • .deb package fails to execute with the following: /opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer: error while loading shared libraries: libnw.so: cannot open shared object file: No such file or directory

Debian GNU/Linux 11 (bullseye)

  • Portable works mostly works. Failing video-export.
    • video driver init fail
    • no export due, no save-as dialog.
$ ./betaflight-blackbox-explorer 
libva error: /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so init failed
[1500421:1500429:0906/075331.647163:ERROR:nss_util.cc(349)] After loading Root Certs, loaded==false: NSS error code: -8018
[1500421:1500429:0906/075331.647456:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
[1500421:1500429:0906/075344.134297:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
[1500387:1500410:0906/075347.098626:ERROR:select_file_dialog_linux_portal.cc(719)] Portal returned error: org.freedesktop.portal.Error.InvalidArgument: invalid filter: name is empty
  • Automated build ZST issue remains.
  • Local package build: /opt/betaflight/betaflight-blackbox-explorer/betaflight-blackbox-explorer: error while loading shared libraries: libnw.so: cannot open shared object file: No such file or directory

@github-actions

This comment has been minimized.

@betaflight betaflight deleted a comment from github-actions bot Sep 14, 2022
@betaflight betaflight deleted a comment from sonarcloud bot Sep 14, 2022
@betaflight betaflight deleted a comment from github-actions bot Sep 14, 2022
@meoso
Copy link

meoso commented Sep 14, 2022

tested only the linux portable fa30df1 on Debian 11, fails to even open BBL file -- open Dialog can select files, but nothing happens. Dragging-and-drop returns a "save" dialog (and actually does save as a new file to disk 🤪)

$ ./betaflight-blackbox-explorer 
libva error: /usr/lib/x86_64-linux-gnu/dri/iHD_drv_video.so init failed
[503926:503930:0914/075029.723654:ERROR:nss_util.cc(349)] After loading Root Certs, loaded==false: NSS error code: -8018
[503926:503930:0914/075029.724856:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
$ cat /etc/*releas*
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
[...]

@haslinghuis
Copy link
Member Author

@meoso

This comment was marked as outdated.

@meoso
Copy link

meoso commented Sep 14, 2022

My graphics driver issue repaired (TY for link). But it remains about the failure to open files on both Debian 11 and Ubuntu 20.04.5 LTS.

$ ./betaflight-blackbox-explorer 
[5809:5817:0914/082045.581960:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
[5809:5817:0914/082058.024303:ERROR:cert_verify_proc_builtin.cc(612)] No net_fetcher for performing AIA chasing.
 $ cat /etc/*releas*
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.5 LTS"
NAME="Ubuntu"
VERSION="20.04.5 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
[...]

@haslinghuis haslinghuis changed the title Bump NWjs and ffmpeg libraries to 0.67.1 Bump NWjs and ffmpeg libraries to 0.68.1, Node to 16.17.0 Sep 20, 2022
@haslinghuis haslinghuis marked this pull request as draft September 20, 2022 21:09
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@github-actions
Copy link

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@meoso
Copy link

meoso commented Sep 21, 2022

5f1e1ea7

Ubuntu 20.04.5 LTS:

  • Portable: works 100%
  • installed .deb package: fails with same libnw.so issue.

Debian 11:

  • all the same old problems, nothing resolved.

Out of scope, but maybe consider AppImage for distribution compatibility.

@haslinghuis haslinghuis merged commit 18c6d96 into betaflight:master Sep 21, 2022
Finalizing Firmware 4.4 Release automation moved this from Configurator to Closed Sep 21, 2022
@haslinghuis haslinghuis deleted the update-nws branch September 21, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

master (Linux) does not see filenames with capital filename extensions
4 participants