Add PID Error VS Setpoint graph to the analyser

[McGiverGim]

This adds a PID Error VS Setpoint graph to the analyser window, similar to the one of PID Toolbox.

Maximized it looks like:

• By default, it reduces the data to a maximum of 100deg/sec, after tests, this seems a good limit where the PID Error is stable between different flights.
• It shows the data grouped in 10 different groups, to have enough data at each group.
• At the background, in blue, you can see the line with all the data without grouping. In this way you can decide if the data of this group is stable enough or not.
• If you move the slider, you can see the data over 100deg/sec if interested in, and if you press the shift key you can mark any interesting point.

The data shown is only an average of the data received in the Blackbox log. I'm not good at mathematics so I don't know if there is a better statistical function for this, but the data shown seems good enough to me.

[McGiverGim]

Force pushed a little change to fix two Sonar issues. @mikeller it detects 26 new code smells too, but they are in places/files not touched by this PR. Do you want that I fix them? It will complicate the review, but I can do it in a different commit if you want.

[meoso]

love this, but what is the requirement? shows correct on betaflight BBL's but not emufligtht BBL's (only 1 bar/value)

[mikeller]

@meoso: The Betaflight Blackbox Explorer does not support Emuflight log files - you will have to use the Emuflight Blackbox Explorer.

[meoso]

lol, Emuflight Blackbox Explorer does not exist. that's why i was questioning the BBL data requirements :)

[mikeller]

@meoso: I still do not see what this has got to do with Betaflight. If you want to read Emuflight logs and there is no tool for this then you need to open an issue in https://github.com/emuflight/EmuFlight/issues and ask for tooling to read their logs.

[meoso]

i completely understand you don't want to support Emuflight. that is not my issue; i'm not asking you to support Emuflight in any way. BBE reads Emu's BBL's just fine, except this new feature does not display more than one green-bar, so i'm asking what data it uses so that maybe devs can analyze what needs to be recorded or corrected by emuflight. We all know emu is a fork of butterflight which was a fork of BeF 3.x -- trying to figure out what the difference is and what data used to generate this new feature's display. thank you kindly!

[mikeller]

@meoso: See https://github.com/betaflight/betaflight/blob/master/src/main/blackbox/blackbox.c for the data that gets recorded in Betaflight.

[meoso]

thank you very much