Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open window association with --disable-features=nw2 #462

Merged
merged 1 commit into from Aug 2, 2020

Conversation

McGiverGim
Copy link
Member

The opening of a more than one Blackbox windows when double click on the blackbox log file is broken.

The Chrome compatibility is hitting us again...

If was broken here #456 when we disabled de features of nw2 because the export video was broken in #450

I have returned to the old code and now it works. But we need to remember to revert this when we remove the nw2 disable parameter.

Another fast solution for this problem is to modify the export video code here:

function supportsFileWriter() {
return !!(chrome && chrome.fileSystem);
}

Adding a !isNW() to the condition, but this makes the video to be loaded into memory before exporting. I think is better to write directly to disk.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@McGiverGim
Copy link
Member Author

Only as information: there have been several updates to the library we are using here: https://github.com/thenickdude/webm-writer-js and there is one sample of using it with node, so maybe there is a better solution. I simply didn't have time to look into it.

@mikeller mikeller added this to the 3.6.0 milestone Jul 29, 2020
@mikeller
Copy link
Member

This is turning into a game of whack-a-mole around NW2 features - I think we should look into cutting the chase, and do the (considerable) changes to move our apps to NW2, or else look for a new framework to move to - trying to stay in Chrome / NW1 is not going to become less tedious as time goes by.

@mikeller mikeller merged commit afe9d7b into betaflight:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants