Fix open window association with --disable-features=nw2 #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opening of a more than one Blackbox windows when double click on the blackbox log file is broken.
The Chrome compatibility is hitting us again...
If was broken here #456 when we disabled de features of nw2 because the export video was broken in #450
I have returned to the old code and now it works. But we need to remember to revert this when we remove the nw2 disable parameter.
Another fast solution for this problem is to modify the export video code here:
blackbox-log-viewer/js/flightlog_video_renderer.js
Lines 91 to 93 in bbd9a7b
Adding a
!isNW()
to the condition, but this makes the video to be loaded into memory before exporting. I think is better to write directly to disk.