Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom resolution of 1, not 10 #546

Merged
merged 1 commit into from Nov 30, 2021

Conversation

ctzsnooze
Copy link
Member

Quick little PR that changes the zoom (time scaling) steps to be units of 1, rather than 10, with a minimum of 10.

Currently a minimum of 10 allows a maximum of 10s of data in a screen. Minimum of 1 allows up to 100s of data, which is a bit long to be useful, but does give a broad overview of a flight.

Steps of 1 allow zooming to whatever amount you like. With a fast computer this can be done very smoothly, although with a lot of data scrolling is a bit slow.

The downside is that the zoom isn't in neat steps of 10 any more.

It might be nice to have a 'preference' for the size of step, and minimum value, but I don't know how to code that.

I personally find this very useful.

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@haslinghuis haslinghuis added this to the 3.6.0 milestone Nov 29, 2021
@haslinghuis haslinghuis added this to Approval Needed in Finalizing Firmware 4.3 Release via automation Nov 29, 2021
@blckmn
Copy link
Member

blckmn commented Nov 29, 2021

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit f828bce into betaflight:master Nov 30, 2021
Finalizing Firmware 4.3 Release automation moved this from Approval Needed to Finished (Merged) Nov 30, 2021
@ctzsnooze ctzsnooze deleted the Greater-zoom-resolution branch September 27, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants