Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #610

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fix typos #610

merged 1 commit into from
Nov 26, 2022

Conversation

wetheredge
Copy link
Contributor

Fixes some typos found by https://github.com/crate-ci/typos. Mostly in comments, but a few are user-facing.

If it's wanted, I can add the config file I used.

haslinghuis
haslinghuis previously approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG!!! Thanks!

Curious about the config file contents

@haslinghuis haslinghuis added this to the 3.7.0 milestone Nov 25, 2022
@wetheredge
Copy link
Contributor Author

Here's the config file:

# .typos.toml
[files]
extend-exclude = ["css/*.min.css", "js/vendor/**"]

[default.extend-words]
iterm = "iterm"

It does have a false-positive on the ba in this script src.

It also finds Contoller⇒Controller here, but I wasn't sure if I should touch past changelog entries.

@blckmn
Copy link
Member

blckmn commented Nov 25, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

Yes please change Contoller => Controller too

@sonarcloud
Copy link

sonarcloud bot commented Nov 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis merged commit 25e39c6 into betaflight:master Nov 26, 2022
Finalizing Firmware 4.4 Release automation moved this from In progress to Done Nov 26, 2022
@wetheredge wetheredge deleted the typos branch November 26, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
Finalizing Firmware 4.4 Release
  
Done
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wetheredge @blckmn @haslinghuis