Add (e)RPM black box field #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RPM to enabled/disabled black box fields in header dialog - Add escapeRegExp function to tools.js - Escape nameRoot before using as regexp for creating [all] fields in graph_config
|
Kudos, SonarCloud Quality Gate passed!
|
|
Do you want to test this code? Here you have an automated build: |
|
AUTOMERGE: (FAIL)
|
|
@tbolin , Can you update description with details and screencap for prosperity sake? TY |
|
I've added a bit of detail and some screenshots |
haslinghuis
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds formatting of the RPM field from betaflight/betaflight#12823
The field should show up as just RPM and be decoded as RPM and Hz.
The RPM plots are scaled so that they have the correct height relative to each other, so the same height corresponds to the same RPM for all plots.
Also adds an option in Configure graphs to add a graph with all RPM plots.
Depends on https://github.com/betaflight/betaflight/pull/12823