Toggle trace/field visibility #664
Conversation
This comment has been minimized.
This comment has been minimized.
|
i like this; however, would like color bar and possibly the number still be clickable for showing/updating the spectral graph |
|
unsure if this is possible to fix, but i also notice that occasionally, but not 100% of the time, the legend bars disappear during screen-update upon clicking an eye. |
Thanks for noticing this! Yea, it's fixable; oh the joys of CSS! |
|
AUTOMERGE: (FAIL)
|
|
SonarCloud Quality Gate failed.
|
Turns out it was the unnecessary re-rendering of some elements. I also made the other elements clickable to open the analyser. |
|
Do you want to test this code? Here you have an automated build: |
| if (config.isGraphFieldHidden(graphIndex, fieldIndex)) { | ||
| $this.removeClass("glyphicon-eye-open"); | ||
| $this.addClass("glyphicon-eye-close"); | ||
| } else { | ||
| $this.addClass("glyphicon-eye-open"); | ||
| $this.removeClass("glyphicon-eye-close"); | ||
| } |
There was a problem hiding this comment.
Maybe use toggleClass (with state param)
Fixes #380. I removed the equalizer icon from the legend because it had no real function and clicking on the field name had the same functionality (opening the analyzer display). Instead I replaced that icon with a toggle button to show/hide individual traces within a graph. The field names are now underlined on hover to indicate that they are clickable and open the analyser display just like before.