Web build of blackbox explorer #697

chmelevskij · 2024-01-28T08:17:31Z

This is attempt to port blackbox explorer to web with final goal it becoming offline PWA.

To try it out in the browser

yarn start

It will create dev server on http://loclahost:5173:

Live

https://blackbox-viewer.netlify.app/

sonarcloud · 2024-01-28T08:18:11Z

Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

nerdCopter · 2024-01-29T14:53:31Z

WOW, it mostly works.

issue:

sometimes the zoom icon disappears as well.

issue, but BBE continues to work:

Linux, Debian 12, Firefox 115.7.0 ESR:

video open .mp4 works/plays!
video export issue:

import/export workspace worked.

export .csv worked.

chmelevskij · 2024-01-29T17:37:50Z

@nerdCopter I'm even surprised that much worked 😆

github-actions · 2024-02-29T04:33:10Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

chmelevskij · 2024-03-03T14:43:27Z

@nerdCopter where is the zoom icon usually located? I don't think I have it on the usual build 🤔

haslinghuis · 2024-03-03T14:53:02Z

After doing graph setup - click on motors for example - then this pops up:

click in the upper right corner to get the zoom sliders

nerdCopter · 2024-03-04T14:24:38Z

6f797448
scale sliders working as expected:

mituritsyn · 2024-03-05T14:49:29Z

everything works except the button to open a new window, logically it should be hidden, or should open a new tab with explorer.
Checked:
-log upload
-workspace load
-all analyse plots for gyro data
-log header view
-file drag n drop

nerdCopter · 2024-03-05T14:55:40Z

in Chrome, even video export works. save-file comes after the export process.
(export fails in Firefox as expected)

mituritsyn · 2024-03-05T14:56:15Z

oups have an error

graph_map.js:263 Uncaught TypeError: Cannot read properties of undefined (reading 'mapTrailAltitudeColored')
    at MapGrapher.redrawFlightTrail (graph_map.js:263:39)
    at MapGrapher.redrawAll (graph_map.js:252:10)
    at MapGrapher.setCurrentTime (graph_map.js:414:10)
    at animationLoop (main.js:307:24)

in linux terminal:

$ yarn dev
yarn run v1.22.21
$ vite

  VITE v5.0.12  ready in 399 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
Error: The following dependencies are imported but could not be resolved:

  nw.gui (imported by /media/qw/45F882895DB21671/Git/blackbox-log-viewer/js/main.js)

Are they installed?
    at file:///media/qw/45F882895DB21671/Git/blackbox-log-viewer/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:65506:23
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async file:///media/qw/45F882895DB21671/Git/blackbox-log-viewer/node_modules/vite/dist/node/chunks/dep-9A4-l-43.js:64906:38
^C

and after this can't open any log

After restart can't reproduce with same file

chmelevskij · 2024-03-06T07:22:22Z

@mituritsyn thanks for looking into it.
Do you know the exact steps to reproduce

graph_map.js:263 Uncaught TypeError: Cannot read properties of undefined (reading 'mapTrailAltitudeColored')
    at MapGrapher.redrawFlightTrail (graph_map.js:263:39)
    at MapGrapher.redrawAll (graph_map.js:252:10)
    at MapGrapher.setCurrentTime (graph_map.js:414:10)
    at animationLoop (main.js:307:24)

?

nerdCopter · 2024-03-06T14:41:47Z

We would need a 4.5 with GPS positioning log for testing. (i do not have any)

mituritsyn · 2024-03-06T15:45:38Z

@mituritsyn thanks for looking into it. Do you know the exact steps to reproduce

Sorry, can't reproduce anymore. I loaded a log, check some functions, then upload another log and got this error. Initially I thought it is related to log, but I can't reproduce this issue with those files anymore

first btfl_001 (7).txt

second LOG00034.txt

mituritsyn · 2024-03-06T15:46:00Z

We would need a 4.5 with GPS positioning log for testing. (i do not have any)

check second log from comment above

nerdCopter · 2024-03-06T16:39:44Z

6f797448 with LOG00034.txt: same error. multiple executions.

works fine on NWjs app.

chmelevskij · 2024-03-10T15:52:10Z

@nerdCopter @mituritsyn the map issue should be fixed now.

haslinghuis · 2024-03-10T17:56:44Z

Might be a problem with master - with graph_spectrum - have not checked yet.

EDIT: confirm - this is an issue with master - not this PR

haslinghuis · 2024-03-10T18:16:45Z

Great work @chmelevskij - working now

chmelevskij · 2024-03-10T18:17:17Z

@haslinghuis fixed on here.

It seems to be a common problem due to how config/settings are handled. essentially race conditions everywhere and sometimes it's hard to spot if you already changed settings.

haslinghuis · 2024-03-10T18:20:00Z

Yes - lot of spaghetti and global vars in this code base. Reworked configurator lexical scoping - but did not find the time yet here.

demvlad · 2024-03-23T12:04:39Z

@demvlad can you please upload accompanying log file?

I apologize, but i can not repeate this error. All work fine today!

mituritsyn · 2024-03-24T08:18:58Z

is there a way to save workspace? now I have to reload workspace each time I update the page

haslinghuis · 2024-03-26T13:28:52Z

@chmelevskij let's do it. Please rebase so we can merge it.

netlify · 2024-03-26T18:28:34Z

✅ Deploy Preview for origin-blackbox-logviewer ready!

Name	Link
🔨 Latest commit	`7870c10`
🔍 Latest deploy log	https://app.netlify.com/sites/origin-blackbox-logviewer/deploys/660313c4234afc0008d48270
😎 Deploy Preview	https://deploy-preview-697--origin-blackbox-logviewer.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud · 2024-03-26T18:29:50Z

Quality Gate failed

Failed conditions
16 Security Hotspots
5.3% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

* use vite to build webapp version * use all the files as esm modules * remove old nwjs related workflows and nwjs

This comment has been minimized.

Sign in to view

haslinghuis assigned chmelevskij Jan 28, 2024

haslinghuis added the RN: IMPROVEMENT label Jan 28, 2024

github-actions bot added the Inactive label Feb 29, 2024

haslinghuis added pinned and removed Inactive labels Feb 29, 2024

This comment has been minimized.

Sign in to view

chmelevskij force-pushed the feat/vite-web branch from 7dd8d58 to 6f79744 Compare March 3, 2024 15:03

This comment has been minimized.

Sign in to view

chmelevskij force-pushed the feat/vite-web branch from 32b8831 to 195874b Compare March 10, 2024 16:33

chmelevskij force-pushed the feat/vite-web branch from db3141a to dbf60cf Compare March 24, 2024 06:57

chmelevskij added 18 commits March 26, 2024 19:21

feat: build for browser

41132e3

feat: use esm modules for all js

9c25b06

Fix graph_map and more esm module imports

919d54f

Move vendor files to public

d789388

Fix missing imports

e76d7b7

Restructure folders for vite

2591b89

Remove all the gulp and nwjs traces

5e161df

Open new window with a button

f9fe794

feat: move css and workers into public

d740f61

Use imported html2canvas

9c91a39

Use leaflet as esm

4a1dec2

Use bootstrap and lodash modules

a590b48

Use vite to handle css imports

1add209

Put images in public

1ed8196

Fix error with initial config for graphs

1a33eed

Fix saving of user settings for spectrum

2fe6cda

fix: gpx and csv exports

cdd193e

feat: remove vite redundant workflows

7870c10

chmelevskij force-pushed the feat/vite-web branch from dbf60cf to 7870c10 Compare March 26, 2024 18:28

haslinghuis approved these changes Mar 26, 2024

View reviewed changes

chmelevskij merged commit 21cdfca into betaflight:master Mar 26, 2024
5 of 6 checks passed

demvlad pushed a commit to demvlad/blackbox-log-viewer that referenced this pull request Mar 27, 2024

Web build of blackbox explorer (betaflight#697)

cc8396b

* use vite to build webapp version * use all the files as esm modules * remove old nwjs related workflows and nwjs

demvlad pushed a commit to demvlad/blackbox-log-viewer that referenced this pull request Mar 27, 2024

Web build of blackbox explorer (betaflight#697)

20e221b

* use vite to build webapp version * use all the files as esm modules * remove old nwjs related workflows and nwjs

demvlad pushed a commit to demvlad/blackbox-log-viewer that referenced this pull request Mar 27, 2024

Web build of blackbox explorer (betaflight#697)

2aae5fb

* use vite to build webapp version * use all the files as esm modules * remove old nwjs related workflows and nwjs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Web build of blackbox explorer #697

Web build of blackbox explorer #697

chmelevskij commented Jan 28, 2024 •

edited

sonarcloud bot commented Jan 28, 2024

This comment has been minimized.

nerdCopter commented Jan 29, 2024 •

edited

chmelevskij commented Jan 29, 2024

github-actions bot commented Feb 29, 2024

chmelevskij commented Mar 3, 2024

This comment has been minimized.

haslinghuis commented Mar 3, 2024

This comment has been minimized.

nerdCopter commented Mar 4, 2024

mituritsyn commented Mar 5, 2024 •

edited

nerdCopter commented Mar 5, 2024 •

edited

mituritsyn commented Mar 5, 2024 •

edited

chmelevskij commented Mar 6, 2024

nerdCopter commented Mar 6, 2024

mituritsyn commented Mar 6, 2024

mituritsyn commented Mar 6, 2024

nerdCopter commented Mar 6, 2024

chmelevskij commented Mar 10, 2024

haslinghuis commented Mar 10, 2024 •

edited

haslinghuis commented Mar 10, 2024

chmelevskij commented Mar 10, 2024

haslinghuis commented Mar 10, 2024

demvlad commented Mar 23, 2024

mituritsyn commented Mar 24, 2024

haslinghuis commented Mar 26, 2024

netlify bot commented Mar 26, 2024 •

edited

sonarcloud bot commented Mar 26, 2024

Web build of blackbox explorer #697

Web build of blackbox explorer #697

Conversation

chmelevskij commented Jan 28, 2024 • edited

sonarcloud bot commented Jan 28, 2024

Quality Gate failed

This comment has been minimized.

nerdCopter commented Jan 29, 2024 • edited

chmelevskij commented Jan 29, 2024

github-actions bot commented Feb 29, 2024

chmelevskij commented Mar 3, 2024

This comment has been minimized.

haslinghuis commented Mar 3, 2024

This comment has been minimized.

nerdCopter commented Mar 4, 2024

mituritsyn commented Mar 5, 2024 • edited

nerdCopter commented Mar 5, 2024 • edited

mituritsyn commented Mar 5, 2024 • edited

chmelevskij commented Mar 6, 2024

nerdCopter commented Mar 6, 2024

mituritsyn commented Mar 6, 2024

mituritsyn commented Mar 6, 2024

nerdCopter commented Mar 6, 2024

chmelevskij commented Mar 10, 2024

haslinghuis commented Mar 10, 2024 • edited

haslinghuis commented Mar 10, 2024

chmelevskij commented Mar 10, 2024

haslinghuis commented Mar 10, 2024

demvlad commented Mar 23, 2024

mituritsyn commented Mar 24, 2024

haslinghuis commented Mar 26, 2024

netlify bot commented Mar 26, 2024 • edited

✅ Deploy Preview for origin-blackbox-logviewer ready!

sonarcloud bot commented Mar 26, 2024

Quality Gate failed

chmelevskij commented Jan 28, 2024 •

edited

nerdCopter commented Jan 29, 2024 •

edited

mituritsyn commented Mar 5, 2024 •

edited

nerdCopter commented Mar 5, 2024 •

edited

mituritsyn commented Mar 5, 2024 •

edited

haslinghuis commented Mar 10, 2024 •

edited

netlify bot commented Mar 26, 2024 •

edited