Resolved issue of wrong throttle values at spectrum chart when not all log parameters are selected in blackbox settings

[demvlad]

The issues description:
The wrong throttle values at spectrum chart.

This issue appears if to disable some blackbox fields in list at Blackbox page of Betaflight Configurator 4.5 version.
For example - if enabled the gyro, gyro unfiltered and SetPoints only.
There is log file to test this.
test.TXT

The reason of this issue - the difference of logical conditions what are permissed creating of additional computing fields and filling data into it.
(the functions buildFieldNames() and injectComputedFields() in flightlog.js file).
There are the incongruity fields indexes in log algoritmes in this case. As result - We are seeing the scaled yaw setpoint values instead of throttle in my example.
This PR resolved this issue.

[haslinghuis]

Some minor changes. Otherwise LGTM.

[demvlad]

Some minor changes. Otherwise LGTM.

Ok. Thank's.

[nerdCopter]

do you prefer !( || ) or ( && ) for readability here? (two instances)

[haslinghuis]

Morgan's law :)

[demvlad]

do you prefer !( || ) or ( && ) for readability here? (two instances)

I prefer !a &&. !b
One moment, will change..

[nerdCopter]

• approving, but only tested few logs for not-crashing and expected traces.
• not tested with logs missing parameters except the provided test.TXT.

[haslinghuis]

Easier to read now :)

[nerdCopter]

I prefer !a &&. !b One moment, will change..

so the proper gate is not-disabled-gyro && not-disabled-pid ? i think such does make sense.
is this for line 684 as well, i see the commit did not include such.

[demvlad]

Easier to read now :)

morgan law is too clever:)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[demvlad]

• approving, but only tested few logs for not-crashing and expected traces.
• not tested with logs missing parameters except the provided test.TXT.

Yes, this is a thin moment.
The index definition in one place and index using in other with some conditions. I've tryed to do identity conditions. But it is need to test this with different blackbox parameters set combination.

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!