Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning at the status bar while actual log rate is less then required #715

Merged

Conversation

demvlad
Copy link
Contributor

@demvlad demvlad commented Mar 7, 2024

This PR continue improvements, what started in #711
The actual log samples rate warning is showed at the status bar when it much less then setup setting.
The log file for testing:
0.5K Hyro1_RCC_SP_PID_RPM MOTOR 236 bad.TXT

This comment has been minimized.

@nerdCopter
Copy link
Member

image

nerdCopter
nerdCopter previously approved these changes Mar 7, 2024
Code style improvement

Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Mar 7, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Blackbox-Explorer-Linux
Betaflight-Blackbox-Explorer-macOS
Betaflight-Blackbox-Explorer-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter
Copy link
Member

i presume new commits are removing the stale approvals, but the squash and merge button is still active.

@haslinghuis haslinghuis merged commit 1012977 into betaflight:master Mar 7, 2024
5 checks passed
@demvlad demvlad deleted the show_actual_lograte_in_statusbar branch March 7, 2024 17:09
demvlad added a commit to demvlad/blackbox-log-viewer that referenced this pull request Mar 8, 2024
…quired (betaflight#715)

* added warning at the status bar while actual log rate is less then required

* Update js/graph_spectrum_calc.js

Code style improvement

Co-authored-by: Mark Haslinghuis <mark@numloq.nl>

---------

Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants