added various changes for the stick and craft overlay. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeller
requested changes
May 25, 2019
src/blackbox_render.c
Outdated
| @@ -326,10 +347,25 @@ void updateFieldMetadata() | |||
| void drawCommandSticks(int64_t *frame, int imageWidth, int imageHeight, cairo_t *cr) | |||
| { | |||
| double rcCommand[4] = {0, 0, 0, 0}; | |||
| const int stickSurroundRadius = imageHeight / 11, stickSpacing = stickSurroundRadius * 3; | |||
| int stickSurroundRadius = imageHeight / 11; | |||
| if(options.sticksWidth > 0) { | |||
There was a problem hiding this comment.
Can you please add spaces after keywords? In general, the coding style rules from https://github.com/betaflight/betaflight/blob/master/docs/development/CodingStyle.md should be applied wherever possible.
There was a problem hiding this comment.
As suggested spaces have been added to comply with the coding guidelines.
mikeller
approved these changes
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
as described in the Issue
#13
@stylesuxx made some changes to the cleanflight blackbox-tools in the past.
I added some other changes myself and merged them into this repo.
Following things were added/changed :
Added functionality to set stick trail radius
Added functionality to set stick radius.
Add options to resize and position the craft.
Added functioality to render stick traces
Added option for stick crosshair color
Added functionality to set stick area color
Adjusted the default value of the stick color
Added functionality to set sticks color
Adjusted text color stick option
Added new and missing options to the README
Added functionlity for custom text color. This now only applies to the stick overlay labels
Use 0 as default for stick positions
Added functionality to set custom size of the stick overlay boxes
Allow to offset stick overlay from the right and from the top
Added functionality to disable acc display