-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ajoute infos "en savoir plus" pour les charges locatives #4495
Ajoute infos "en savoir plus" pour les charges locatives #4495
Conversation
src/lib/hint.ts
Outdated
@@ -17,6 +17,16 @@ const texts = { | |||
Vous pouvez trouver des missions sur <a href="https://www.1jeune1solution.gouv.fr/service-civique" target="_blank">la page dédié du site 1jeune1solution.gouv.fr</a>. | |||
` | |||
}, | |||
loyer: (): string => { | |||
return ` | |||
<h5>Que sont les charges locatives ?</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je trouve ta structure HTML particulière, deux h5 et pas de paragraphe ou d'autres types de balises de texte.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est inclu dans une balise p v-html.
J'ai mis des h5 pour le style proposé par le DSFR. Ça pose problème qu'il y en ait deux ?
Qu'est-ce que tu proposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je peux refacto les autres contenus textuels des hint en ajoutant des balises p
car elles n'en avaient pas à l'origine et remplacer la balise <p v-html>
par une balise <span v-html>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Et de passer le reste en mode balise <p>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, le problème que j'avais était esthétique car le style du DSFR par défaut sur les h3 n'était pas adapté mais en ajoutant la class fr-text--lg
ça passe mieux.
J'ai modifié selon tes suggestions.
e49894c
to
d0f6679
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parfait, merci @Shamzic pour les modifications.
No description provided.