Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiche, appro : montrer l'état (TD ou non) du diag #3911

Merged
merged 6 commits into from
May 14, 2024

Conversation

hfroot
Copy link
Collaborator

@hfroot hfroot commented May 13, 2024

Closes #3887

Screenshot 2024-05-13 at 13-35-35 ma cantine
Screenshot 2024-05-13 at 13-35-25 ma cantine
Screenshot 2024-05-13 at 13-35-17 ma cantine
Screenshot 2024-05-13 at 13-35-06 ma cantine

@hfroot hfroot requested a review from alemangui May 13, 2024 11:35
@alemangui
Copy link
Collaborator

@hfroot Est-ce qu'on veut le même schéma de couleur dans le graphique « Comparer » ?

Screencast.from.13-05-24.15.59.15.webm

@@ -9,6 +9,7 @@
@input="(v) => $emit('input', v)"
style="background: #eeeeee;"
>
<!-- TODO: consider using a different component if we don't want role="alert" -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Also I'm not a fan of having to put icon=" " if we don't want an icon. For another PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally agreed. I started changing it in this PR but things got a bit complicated so I figured to do it in another PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hfroot
Copy link
Collaborator Author

hfroot commented May 14, 2024

@hfroot Est-ce qu'on veut le même schéma de couleur dans le graphique « Comparer » ?

Screenshot 2024-05-14 at 11-58-30 ma cantine

je l'ai mis en gris comme les maquettes

@hfroot hfroot merged commit e674d01 into staging May 14, 2024
4 of 5 checks passed
@hfroot hfroot deleted the published-diag-status branch May 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Affiche, appro : information sur état du diagnostic
2 participants