Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajout d'une barre de navigation #46

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Ajout d'une barre de navigation #46

merged 6 commits into from
Jan 11, 2021

Conversation

Forster-Groux
Copy link
Contributor

@Forster-Groux Forster-Groux commented Jan 6, 2021 •
edited

#42

@Forster-Groux Forster-Groux mentioned this pull request Jan 7, 2021
Closed
hfroot
hfroot requested changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@hfroot hfroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que on doit avoir la fiche assets/logo-ma-cantine.png ? Je ne vois pas ou elle est utiliser.

front-end/src/components/TheNavbar.vue Show resolved Hide resolved
front-end/src/components/TheNavbar.vue Outdated Show resolved Hide resolved
front-end/src/router/index.js Show resolved Hide resolved
front-end/src/App.vue Show resolved Hide resolved
front-end/src/components/TheNavbar.vue Show resolved Hide resolved
@Forster-Groux Forster-Groux self-assigned this Jan 8, 2021
hfroot
hfroot approved these changes Jan 8, 2021
View reviewed changes
Copy link
Collaborator

@hfroot hfroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Les changes sont bons. Le dernier chose c'est que la barre n'est pas responsif sur les écrans petits. Peut-être on peut discuter si on veut ajouter ça dans notre 'definition of done' pour l'instant à lundi?

@Forster-Groux Forster-Groux merged commit 1282f81 into main Jan 11, 2021
@Forster-Groux Forster-Groux deleted the add-navbar branch January 11, 2021 19:53
alemangui pushed a commit that referenced this pull request Oct 15, 2021
@Forster-Groux
Merge pull request #46 from betagouv/add-navbar
3bd9859 
Ajout d'une barre de navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfroot hfroot hfroot approved these changes

@JenniferStephan JenniferStephan Awaiting requested review from JenniferStephan

Assignees

@Forster-Groux Forster-Groux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Forster-Groux @hfroot