🎨🔥 change la recherche d'entreprise #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johangirod
commented
Oct 1, 2019
•
johangirod
commented
- On utilise un nouveau composant qui se base sur la dernière version de l'api SIRENE
- On sépare les données entre la simulation des cotisations et la création d'entreprise
johangirod
force-pushed
the
nouvelle-recherche
branch
from
d1e9247
to
e9b3936
Compare
- On utilise un nouveau composant qui se base sur la dernière version de l'api SIRENE - On sépare les données entre la simulation des cotisations et la création d'entreprise - On gagne des lignes !
johangirod
force-pushed
the
nouvelle-recherche
branch
2 times, most recently
from
f05ae98
to
a967a8f
Compare
johangirod
force-pushed
the
nouvelle-recherche
branch
from
a967a8f
to
1abdc66
Compare
|
Le bouton « J'ai déjà déclaré mon entreprise » ne fonctionne pas sur https://deploy-preview-705--syso.netlify.com/entreprise/statut-juridique |
|
Je le supprime, il n'a pas de logique de l'afficher à ce moment là. |
|
J'ai oublié de te faire le retour suivant :
Ce numéro seul n'est pas très clair, ajouter un label "SIREN" ? |
mquandalle
reviewed
Nov 11, 2019
| type: 'EXISTING_COMPANY::SET_SIREN', | ||
| siren | ||
| }) | ||
| const companyDetails = await fetchCompanyDetails(siren) |
There was a problem hiding this comment.
Il est possible que companyDetails soit null ce qui fait planter le site.
https://sentry.data.gouv.fr/betagouvfr/mon-entreprise/issues/1862838/
Une solution triviale c'est de rajouter un if (companyDetails === null) return mais il y a peut-être mieux pour gérer l'ensemble des requêtes réseau ?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.