[#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). #574

MBrandone · 2017-10-27T16:13:06Z

No description provided.

florianEnoh · 2017-10-30T09:43:44Z

api/lib/domain/models/data/assessment.js

+  },
+
+  isCompleted() {
+    return !!(this.get('estimatedLevel') && this.get('pixScore'));


Je permets de mettre un warning sur cette écriture.
On a gagné en ligne mais perdu en lisibilité.
A la limite je proposerais de caster via le constructeur qui donne plus de clarté. Eg:
return Boolean(this.get('estimatedLevel') && this.get('pixScore'))

florianEnoh · 2017-10-30T09:54:02Z

live/app/adapters/challenge.js

-      }
-      return RSVP.resolve(challenge);
-    });
+  queryRecord(store, type, query) {


Pourquoi être passé de queryNext à queryRecord ?

queryNext n'est pas un standard Ember. C'était une fonction qui avait été ajouté à l'adapter et qui modifiait le comportement lorsqu'on requetait le store (resolve null au lieu de reject par exemple).
queryRecord est une fonction standard Ember, et on ne fait que la surchargé (plus facile à appeler dans l'implementaion, et à tester derrière). On revient dans les standards.

florianEnoh · 2017-10-30T10:02:59Z

live/app/components/competence-level-progress-bar.js

@@ -34,9 +35,16 @@ export default Ember.Component.extend({
  canUserStartCourse: Ember.computed('courseId', 'hasLevel', function() {
    const courseId = this.get('courseId');
    const hasLevel = this.get('hasLevel');
-    if (!courseId || hasLevel) {
+    const assessmentId = this.get('assessmentId');
+    if (!courseId || hasLevel || assessmentId) {


Je pense qu'on peut extraire cette condition dans une petite fonction, à première vu je ne comprends pas l'intention de la condition

done
Ce sera 'hasAFinishedAssessment'

finalement, on return l'inverse du boolean, ça va plus vite

florianEnoh · 2017-10-30T10:15:50Z

live/app/components/competence-level-progress-bar.js

+  canUserResumeAssessment : Ember.computed('assessmentId', 'hasLevel', function() {
+    const hasLevel = this.get('hasLevel');
+    const assessmentId = this.get('assessmentId');
+    return !hasLevel && assessmentId != null && assessmentId != '' ;


Je propose:
return !hasLevel && Ember.isPresent(assessmentId);

bien vu done

…petence

…mpetence

…n adapter

…smentRepository#findLastAssessmentsForEachCoursesByUser

…cannot follow each other

…s la page du profil (US-565). (#574) * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * fix bug

… (US-924). (#585) * Add Sorted skills * litlle refacto of user-service_test * Massive function rename * refacto * refacto * [US-880] resolve Bug from func review (only skills from 1st assessment) * [US-880] delete unused function * [#563] [CLEANUP] Nettoyage de code côté front (US-867). (#563) * Remove useless route courses.get-challenge-preview * Micro-refactor router.js to use new Ember 2.16 import * Remove useless route file 'create-assessment-old' * Rename route 'challenges.get-preview' into 'challenges.preview' * Rename route 'challenges.preview' into challenge-preview * Add a '/' before 'rejoindre' route path * Rename route (and files)' assessments.get-challenge' into 'assessments.challenge' * Rename route (and files)' assessments.results' into 'assessments.results' * Refactor assessments routes to declare and use nesting routes (with perf optimizations as a result ^^) * Fix little regression on 'validate' button management * Rename route 'assessments.get-comparison' into 'assessments.comparison' * Remove useless initializer * [#576] [TECH] Mise à jour de la config eslint pour Mocha. [#576] [TECH] Mise à jour de la config eslint pour Mocha * [US-880] integrating review comments * Fixing linter * [#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). (#574) * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * fix bug * [#578] [FEATURE] Mise à jour des logos des ministères de l'éducation (Sup & SCO) (US-822) (#578) * Update Mensr logo * Add alternative text to ministries logo * [#577] [CLEANUP] Modification des dates de fin d'inscriptions pour les etablissements (US-865) (#577) * modify date of inscription end * delete little note * delete unused style * Update lycee section content * Update sup section content * Add new component tutorial-panel (#582) * [#581] [FEATURE] Bouton seconde chance pour que l'utilisateur repasse la compétence (US-863). * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] implement route assessment resume and make a little change on adapter * wip clean mirage for functional testing * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * delete skip * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * Correct error for assessment with 0 pix score which was consider as notEvaluated * Add simple visible button to replay assessment + clean code * Correct test and clean code * Clean code after rebase * Clean code after rebase * Add findLastAssessmentsForEachCoursesByUser * Fix tests * Extracting logic from Profile constructor to service * Defining warnings * [#580] [BUGFIX] Correction du loader qui disparaît de façon impromptue au démarrage d'un test de positionnement (US-917). (#580) * Use replaceWith instead of transitionTo in order to have a better browser history, cf. https://guides.emberjs.com/v2.16.0/routing/redirection/#toc-toggle * Add template on route create-assessment (the fix is here) because afterModel() hook sends a notification to the Ember engine that it can stop the loader + change the loading text for a better user experience. * Remove routes nesting because, according to Ember, it is a good mechanism if we use a common templates for all the child routes. Here, it is not the case and it adds a little complexity that is too much. * Force Ember to reload assessment model from results page in order to fix bug

Akhilian · 2017-11-17T15:43:35Z

ETQ Utilisateur logué, JV reprendre un test en cours

… évaluation de type certification (US-893) (#589) * Add Sorted skills * litlle refacto of user-service_test * Massive function rename * refacto * refacto * [US-880] resolve Bug from func review (only skills from 1st assessment) * [US-880] delete unused function * [#563] [CLEANUP] Nettoyage de code côté front (US-867). (#563) * Remove useless route courses.get-challenge-preview * Micro-refactor router.js to use new Ember 2.16 import * Remove useless route file 'create-assessment-old' * Rename route 'challenges.get-preview' into 'challenges.preview' * Rename route 'challenges.preview' into challenge-preview * Add a '/' before 'rejoindre' route path * Rename route (and files)' assessments.get-challenge' into 'assessments.challenge' * Rename route (and files)' assessments.results' into 'assessments.results' * Refactor assessments routes to declare and use nesting routes (with perf optimizations as a result ^^) * Fix little regression on 'validate' button management * Rename route 'assessments.get-comparison' into 'assessments.comparison' * Remove useless initializer * [#576] [TECH] Mise à jour de la config eslint pour Mocha. [#576] [TECH] Mise à jour de la config eslint pour Mocha * [US-880] integrating review comments * Fixing linter * [#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). (#574) * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * fix bug * [#578] [FEATURE] Mise à jour des logos des ministères de l'éducation (Sup & SCO) (US-822) (#578) * Update Mensr logo * Add alternative text to ministries logo * [#577] [CLEANUP] Modification des dates de fin d'inscriptions pour les etablissements (US-865) (#577) * modify date of inscription end * delete little note * delete unused style * Update lycee section content * Update sup section content * Add new component tutorial-panel (#582) * [#581] [FEATURE] Bouton seconde chance pour que l'utilisateur repasse la compétence (US-863). * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] implement route assessment resume and make a little change on adapter * wip clean mirage for functional testing * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * delete skip * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * Correct error for assessment with 0 pix score which was consider as notEvaluated * Add simple visible button to replay assessment + clean code * Correct test and clean code * Clean code after rebase * Clean code after rebase * Add findLastAssessmentsForEachCoursesByUser * Fix tests * Extracting logic from Profile constructor to service * Defining warnings * [#580] [BUGFIX] Correction du loader qui disparaît de façon impromptue au démarrage d'un test de positionnement (US-917). (#580) * Use replaceWith instead of transitionTo in order to have a better browser history, cf. https://guides.emberjs.com/v2.16.0/routing/redirection/#toc-toggle * Add template on route create-assessment (the fix is here) because afterModel() hook sends a notification to the Ember engine that it can stop the loader + change the loading text for a better user experience. * Remove routes nesting because, according to Ember, it is a good mechanism if we use a common templates for all the child routes. Here, it is not the case and it adds a little complexity that is too much. * Remove toJSON() from AirTableRecord in model objects * adding missing tests to challenge-tests * add certifications/results route * add tests to certifications/results route * add certification-banner component * WIP styling certification + custom route /certifications for dev * Add top level template-component and related tests * lint compte-test * Update according to code review * updating certification result message * renaming certification-results-template into certification-results-page

MBrandone changed the title ~~[#] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565).~~ [#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). Oct 27, 2017

florianEnoh reviewed Oct 30, 2017

View reviewed changes

jbuget force-pushed the 565-resume-test branch from 5a4a072 to 8903c34 Compare November 3, 2017 09:13

MBrandone force-pushed the 565-resume-test branch 2 times, most recently from 70905c8 to 820946e Compare November 3, 2017 15:40

florianEnoh added the [Tech] Changes required label Nov 6, 2017

MBrandone and others added 24 commits November 6, 2017 17:08

[US-565] Add link reprendre le test when assessment is related to com…

f6790d4

…petence

[US-565] create data to test functionnally on mirage

f8fec2d

[US-565] add assessmentId field in competence model

02a058d

[US-565] implement link reprendre when assessment is present for a co…

fa4e6df

…mpetence

[US-565] create resume assessment route

6262c98

[US-565] get assessment infos in resume assessment route

49b5d76

[US-565] clean tests

62f043f

[US-565] implement route assessment resume and make a little change o…

75c54a1

…n adapter

delete only

bf50cda

wip clean mirage for functional testing

a9b6797

Fix Mirage and make resume works (but break tests)

fd78046

Take into account dynamic assessment in Mirage

87137f6

finalize mirage routes refacto

8580e3f

Rename AssessmentRepository#findCompletedAssessmentsByUserId by Asses…

64f195e

…smentRepository#findLastAssessmentsForEachCoursesByUser

[US-565] implement assessment repo, get all assessments from one user

4b0f900

[US-565] add assessment id to competence in profile object

64de78c

[US-565] implement profile-serializer with assessment-id

6a85b5b

[US-565] change api and adapter front

abbfc6d

Undo assessment-service fix

506593f

skip acceptance tests which fail (temporary action)

444fa22

Re implement findCompletedAssessmentByUser

9ff86ae

Unskip and fix broken acceptance tests on challenge validation

18bc3ef

remove acceptance test on deprecated behaviour: two timed challenges …

dc9cce7

…cannot follow each other

delete skip

245d452

MBrandone added 2 commits November 6, 2017 17:32

[US-880] changes from tech review

adb3385

try to resolve acceptance test after rebase

0bce7bf

MBrandone force-pushed the 565-resume-test branch from 6c6d940 to 0bce7bf Compare November 6, 2017 17:07

MBrandone added 2 commits November 7, 2017 12:37

fix errors from rebase

69845cc

fix bug

74849ed

MBrandone added [Func] Changes validated [Tech] Changes done and removed [Tech] Changes required labels Nov 8, 2017

MBrandone merged commit 0fdb17f into dev Nov 8, 2017

MBrandone deleted the 565-resume-test branch November 8, 2017 16:41

Akhilian added [Tech] Changes validated and removed [Tech] Changes done labels Nov 17, 2017

Akhilian added this to the v1.28.0 milestone Nov 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). #574

[#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). #574

MBrandone commented Oct 27, 2017

florianEnoh Oct 30, 2017

MBrandone Nov 6, 2017

florianEnoh Oct 30, 2017

MBrandone Oct 30, 2017

florianEnoh Oct 30, 2017

MBrandone Nov 6, 2017

MBrandone Nov 6, 2017

florianEnoh Oct 30, 2017

MBrandone Nov 6, 2017

Akhilian commented Nov 17, 2017

[#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). #574

[#574] [FEATURE] Possibilité de reprendre un test déjà commencé depuis la page du profil (US-565). #574

Conversation

MBrandone commented Oct 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Akhilian commented Nov 17, 2017