This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
[#585] [BUGFIX] Correction affichage du score sur la page de résultat (US-924). #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove useless route courses.get-challenge-preview * Micro-refactor router.js to use new Ember 2.16 import * Remove useless route file 'create-assessment-old' * Rename route 'challenges.get-preview' into 'challenges.preview' * Rename route 'challenges.preview' into challenge-preview * Add a '/' before 'rejoindre' route path * Rename route (and files)' assessments.get-challenge' into 'assessments.challenge' * Rename route (and files)' assessments.results' into 'assessments.results' * Refactor assessments routes to declare and use nesting routes (with perf optimizations as a result ^^) * Fix little regression on 'validate' button management * Rename route 'assessments.get-comparison' into 'assessments.comparison' * Remove useless initializer
[#576] [TECH] Mise à jour de la config eslint pour Mocha
…ills [#575] [FEATURE] Classer les acquis par odre de difficulté décroissante lors de la récupération pour un utilisateur donné - (US-880)
…s la page du profil (US-565). (#574) * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * fix bug
…(Sup & SCO) (US-822) (#578) * Update Mensr logo * Add alternative text to ministries logo
…s etablissements (US-865) (#577) * modify date of inscription end * delete little note * delete unused style * Update lycee section content * Update sup section content
… la compétence (US-863). * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] create data to test functionnally on mirage * [US-565] add assessmentId field in competence model * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] get assessment infos in resume assessment route * [US-565] clean tests * [US-565] implement route assessment resume and make a little change on adapter * delete only * wip clean mirage for functional testing * Fix Mirage and make resume works (but break tests) * Take into account dynamic assessment in Mirage * finalize mirage routes refacto * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * [US-565] implement assessment repo, get all assessments from one user * [US-565] add assessment id to competence in profile object * [US-565] implement profile-serializer with assessment-id * [US-565] change api and adapter front * Undo assessment-service fix * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * Unskip and fix broken acceptance tests on challenge validation * remove acceptance test on deprecated behaviour: two timed challenges cannot follow each other * delete skip * [US-880] changes from tech review * try to resolve acceptance test after rebase * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * [US-565] Add link reprendre le test when assessment is related to competence * [US-565] implement link reprendre when assessment is present for a competence * [US-565] create resume assessment route * [US-565] implement route assessment resume and make a little change on adapter * wip clean mirage for functional testing * Rename AssessmentRepository#findCompletedAssessmentsByUserId by AssessmentRepository#findLastAssessmentsForEachCoursesByUser * skip acceptance tests which fail (temporary action) * Re implement findCompletedAssessmentByUser * delete skip * fix errors from rebase * Add status in competence in progress bar * Add function to set status to competences in profile * Add Status in competence of profile and add status in tests * Rebase work for relaunch test + Add set status correctly for competences * Add simple link to replay assessment + modify check to continue assessment * Correct error for assessment with 0 pix score which was consider as notEvaluated * Add simple visible button to replay assessment + clean code * Correct test and clean code * Clean code after rebase * Clean code after rebase * Add findLastAssessmentsForEachCoursesByUser * Fix tests * Extracting logic from Profile constructor to service * Defining warnings
…e au démarrage d'un test de positionnement (US-917). (#580) * Use replaceWith instead of transitionTo in order to have a better browser history, cf. https://guides.emberjs.com/v2.16.0/routing/redirection/#toc-toggle * Add template on route create-assessment (the fix is here) because afterModel() hook sends a notification to the Ember engine that it can stop the loader + change the loading text for a better user experience. * Remove routes nesting because, according to Ember, it is a good mechanism if we use a common templates for all the child routes. Here, it is not the case and it adds a little complexity that is too much.
jbuget
changed the title
jbuget
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fix bug