Implement MockHTTPResponse.close #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged #202, #205, and #206 on my fork and then rebased this commit onto them. I updated the commit slightly to pass the docstring checks. All of the tox checks pass in my build here: Once #202, #205, and #206 are merge, I think this can be as well. Once this is merged, #200 should be fixed as this project will be compatible with urllib3 v2. |
|
Could this be a good time to revive this? Is any work still required before this can be merged? |
If @iv-m wants to rebase this I'd merge it. If someone else wants to resubmit on their behalf that's fine by me too |
iv-m
force-pushed
the
mockhttprequest-close
branch
from
b7ade6b
to
48d0d62
Compare
Done) |
sigmavirus24
requested changes
Feb 6, 2024
There's no need for `self.__closed` as we don't need something so hidden or mangled for this purpose, plus it doesn't really hide anything at all.
sigmavirus24
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#200