Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jackson version to post 2.x.x #71

Closed
reistiago opened this issue Jun 25, 2014 · 6 comments
Closed

Update Jackson version to post 2.x.x #71

reistiago opened this issue Jun 25, 2014 · 6 comments

Comments

@reistiago
Copy link

This would allow to use afterburner module that would improve serialization and deserialization performance

https://github.com/FasterXML/jackson-module-afterburner

@eswdd eswdd added this to the Release 3.2 Candidates milestone Jun 26, 2014
@eswdd eswdd added M labels Jun 26, 2014
@eswdd
Copy link
Contributor

eswdd commented Jun 26, 2014

Locally I moved over to a post 2.x.x release this morning, which wasn't too painful. Unit tests pass fine.
This requires me to do a bit of refactoring of where the ObjectMapper is created to enable the config to allow plugging in of this module. The default config will be to enable it, but the config will allow disabling it in case there are any probs.

@reistiago
Copy link
Author

Cool, I'll keep an eye on this, to check for progress.

If you want, push a branch with your changes and I can try to help developing the remaining bits.

Thanks

@reistiago
Copy link
Author

Thanks for the push. As far as I can quickly see this is complete and not needing me to do anything more.

Do you have any timeframe to release a version with this changes?

@eswdd
Copy link
Contributor

eswdd commented Jun 27, 2014

I'm just waiting for the build to complete successfully - there's one test failure which looks related to this change so I'll fix that before marking as closed.

We don't have any timeframes for our next release as yet, but given we release approx every 3-4 months I would anticipate us doing a release in July or August.

eswdd added a commit that referenced this issue Jun 27, 2014
…alid and the jackson upgrade changed the exception cause hierarchy in the case of invalid enum values
@eswdd
Copy link
Contributor

eswdd commented Jun 28, 2014

Hopefully that's the last of the tests which were wrong, so assuming the build now passes this will be closed.

@eswdd
Copy link
Contributor

eswdd commented Jun 28, 2014

All tests passing.

@eswdd eswdd closed this as completed Jun 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants