Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jetty to >= 9.1 #95

Closed
andredasilvapinto opened this issue Jan 20, 2015 · 7 comments
Closed

Upgrade Jetty to >= 9.1 #95

andredasilvapinto opened this issue Jan 20, 2015 · 7 comments

Comments

@andredasilvapinto
Copy link
Contributor

so we can expose Jetty's QTP queue size.

Jetty 9.2.6 has it:
http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't:
http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick any >= 9.1 version, as this functionality was introducted in 9.1.0:
http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

@eswdd
Copy link
Contributor

eswdd commented Jan 20, 2015

I have no objection to moving straight to 9.2.6

We're only on 9.0.6 as that was the latest version when we last updated all
the library versions.

On 20 January 2015 at 11:38, André Pinto notifications@github.com wrote:

so we can expose Jetty's QTP queue size.

Jetty 9.26 has it:

http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't:

http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick
any >= 9.1 version, as this functionality was introducted in 9.1.0:

http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29


Reply to this email directly or view it on GitHub
#95.

@eswdd
Copy link
Contributor

eswdd commented Jan 21, 2015

Started this am - jars a bit slow to load on a fast train. Latest is now
9.2.7 so have used that. Some minor api diffs which shouldnt be problematic
and then will see how tests do..
On 20 Jan 2015 13:50, "Simon Matic Langford" simon@exemel.co.uk wrote:

I have no objection to moving straight to 9.2.6

We're only on 9.0.6 as that was the latest version when we last updated
all the library versions.

On 20 January 2015 at 11:38, André Pinto notifications@github.com wrote:

so we can expose Jetty's QTP queue size.

Jetty 9.26 has it:

http://download.eclipse.org/jetty/9.2.6.v20141205/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29

Jetty 9.0.6 (Cougar's version) doesn't:

http://archive.eclipse.org/jetty/9.0.6.v20130930/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html

If we don't want to migrate to the very latest Jetty version, we can pick
any >= 9.1 version, as this functionality was introducted in 9.1.0:

http://archive.eclipse.org/jetty/9.1.0.v20131115/apidocs/org/eclipse/jetty/util/thread/QueuedThreadPool.html#getQueueSize%28%29


Reply to this email directly or view it on GitHub
#95.

@andredasilvapinto
Copy link
Contributor Author

Great. Having visibility of the QTP queue size is a useful feature in the Betfair context.

@eswdd
Copy link
Contributor

eswdd commented Jan 22, 2015

Hitting some probs with our integration tests. Will play for a bit
otherwise will try dropping back a bit...
On 21 Jan 2015 09:42, "André Pinto" notifications@github.com wrote:

Great. Having visibility of the QTP queue size is a useful feature in the
Betfair context.


Reply to this email directly or view it on GitHub
#95 (comment).

@eswdd
Copy link
Contributor

eswdd commented Jan 23, 2015

9.2.7 proved problematic, so rather than hunt for a working 9.2.x release
i've gone back to 9.1.5 which passed all tests locally.
On 22 Jan 2015 08:47, "Simon Matic Langford" simon@exemel.co.uk wrote:

Hitting some probs with our integration tests. Will play for a bit
otherwise will try dropping back a bit...
On 21 Jan 2015 09:42, "André Pinto" notifications@github.com wrote:

Great. Having visibility of the QTP queue size is a useful feature in the
Betfair context.


Reply to this email directly or view it on GitHub
#95 (comment).

@eswdd eswdd self-assigned this Jan 23, 2015
@eswdd eswdd added this to the Release 3.2.0 milestone Jan 23, 2015
@andredasilvapinto
Copy link
Contributor Author

👍 this is much valued here. Will try it locally on SEAS today.

@eswdd
Copy link
Contributor

eswdd commented Jan 25, 2015

Tests all passing on travis

@eswdd eswdd closed this as completed Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants