Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsheets error: Unknown pattern "d/m/yyyy". #95

Closed
harishanumula opened this issue Jul 29, 2021 · 15 comments · Fixed by #122
Closed

gsheets error: Unknown pattern "d/m/yyyy". #95

harishanumula opened this issue Jul 29, 2021 · 15 comments · Fixed by #122

Comments

@harishanumula
Copy link

It is getting parsed properly in the google sheets, even showing a calendar dropdown in sheets, but getting this error when importing in superset. @betodealmeida

@betodealmeida
Copy link
Owner

Thanks, @harishanumula! I'll do a quick fix to include the pattern. I'm currently working on a branch (https://github.com/betodealmeida/shillelagh/tree/icu) that will handle any pattern, but it's going to take some time.

@harishanumula
Copy link
Author

Thanks @betodealmeida, please add all the date formats possible with date. like (mm/dd/yyyy), (dd/mm/yy), (dd/mm/yyyy)

@RhysDavis
Copy link

+1 to this!

@jesse042811
Copy link

Hey @betodealmeida - I am facing a similar issue with my dashboard.

Unknown pattern "yyyy-mm-dd".

@betodealmeida
Copy link
Owner

Thanks @jesse042811 — working on it right now, I should have a fix in the next few days.

@samlopezic
Copy link

Hi @betodealmeida thanks for looking into this. Adding my error.

Unknown pattern "dd-mm-yyyy"

Working on a Google Sheet with dates formated for Chile.

@jesse042811
Copy link

Any update on this bug? @betodealmeida

@betodealmeida
Copy link
Owner

@jesse042811 not yet, working on it tonight.

Can you share a spreadsheet where the problem happens so I can test?

@jesse042811
Copy link

jesse042811 commented Aug 30, 2021 via email

@betodealmeida
Copy link
Owner

@jesse042811 no, I really meant spreadsheet — a link to a spreadsheet where the date is formatted as "yyyy-mm-dd", so I can test the solution. It can have just 1 column and bogus data. I'll also create one to test, but I might overlook something, so if someone has a link that I can test it would be better.

@samlopezic
Copy link

Hi @betodealmeida , here is a spreeadsheet with pattern "dd-mm-yyyy"

https://docs.google.com/spreadsheets/d/1yL0dMFQpQTxXXMWEOcj8GRc90NBUz4aKVOfeMUCk2SM/edit?usp=sharing

Thanks

@betodealmeida betodealmeida linked a pull request Aug 31, 2021 that will close this issue
@betodealmeida
Copy link
Owner

@harishanumula @RhysDavis @jesse042811 @samlopezic I just released 1.0.4, with a full parser/formatter that should support any patterns. I tested with the patterns that you provided and also with the sheet that @samlopezic linked, and everything worked successfully.

Sorry for the delay, but I wanted to write a robust solution that should handle custom formats, not just the most popular ones. Let me know if you have any other problems!

@jesse042811
Copy link

@betodealmeida
Still not working for me, here is a spreadsheet from a project with a similar format. https://docs.google.com/spreadsheets/d/1Azlmysl62rK6a3fW2Tc287Egxoo3QvIMKhJ-u8eAMjc/edit#gid=0

@betodealmeida betodealmeida reopened this Aug 31, 2021
@betodealmeida
Copy link
Owner

@jesse042811 can you share the spreadsheet with roberto@dealmeida.net? I'll take a look.

@betodealmeida
Copy link
Owner

Closing since I talked with @jesse042811 and the problem they're seeing is with an older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants