Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regression models for plotting etc #11

Merged
merged 6 commits into from
Feb 20, 2018
Merged

Conversation

erikbern
Copy link
Contributor

@erikbern erikbern commented Feb 20, 2018

This removes the old scipy.optimize-based models and switches everything to the tensorflow-based models I put together last night. Cleans up a lot of code and the new models should be faster and more robust.

Two things to fix shortly:

  1. The plotting is a bit dumb – we're still fitting separate models for each group, so there's really no benefit from thinking about it as a regression model.
  2. Compiling the model adds several seconds over overhead each time the model is fit. Should figure out a way to reuse the computational graph.

@coveralls
Copy link

coveralls commented Feb 20, 2018

Coverage Status

Coverage increased (+4.3%) to 76.547% when pulling c152e19 on use-regression-models into b22b03c on master.

@erikbern erikbern merged commit 917d075 into master Feb 20, 2018
@erikbern erikbern deleted the use-regression-models branch February 20, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants