Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The state is lost when working with react-router-dom #17

Closed
loia5tqd001 opened this issue Nov 3, 2021 · 5 comments
Closed

The state is lost when working with react-router-dom #17

loia5tqd001 opened this issue Nov 3, 2021 · 5 comments

Comments

@loia5tqd001
Copy link
Contributor

Here is the codesandbox to reproduce the problem.

Reproduce steps:

  • In Home page, toggle value from false to true.
  • Go to About page,
  • Go back to Home page. Expect value to be still true. But it's false.
loia5tqd001 added a commit to loia5tqd001/use-between that referenced this issue Nov 3, 2021
@loia5tqd001
Fix betula#17
aacf4e4
loia5tqd001 added a commit to loia5tqd001/use-between that referenced this issue Nov 4, 2021
@loia5tqd001
Fix betula#17
ed441db
loia5tqd001 added a commit to loia5tqd001/use-between that referenced this issue Nov 4, 2021
@loia5tqd001
Fix betula#17
1c26e41
@betula
Copy link
Owner

betula commented Nov 4, 2021

What do you think of this release message?

What's New

Version 0.1.0

  • Now the shared state will not be lost if all components using it are unmounted. (issue)
  • Minor bug fix. (commit)

@loia5tqd001
Copy link
Contributor Author

I think it's pretty OK, let's do it 👀 😂 @betula

@betula
Copy link
Owner

betula commented Nov 4, 2021

PR: #18

@betula betula mentioned this issue Nov 4, 2021
Merged
@betula betula closed this as completed in 3da9709 Nov 4, 2021
@betula
Copy link
Owner

betula commented Nov 4, 2021

Thanks a lot! @loia5tqd001
Great work! 👍

@betula
Copy link
Owner

betula commented Nov 5, 2021

Hi @loia5tqd001,

Release 0.1.0 is ready! I appreciate your help! Many thanks!

Happy Coding 😊

@betula betula mentioned this issue Jul 17, 2022
Closed
@snyk-bot snyk-bot mentioned this issue Nov 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@betula @loia5tqd001