Log the notification reply if one exists #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverloo
reviewed
Jun 1, 2018
| @@ -20,6 +20,9 @@ self.addEventListener('activate', function(event) { | |||
| self.addEventListener('fetch', function(event) {}); | |||
|
|
|||
| self.addEventListener('notificationclick', function(event) { | |||
| if (event.reply) { | |||
| alert('User replied: "' + event.reply + '"'); | |||
| } | |||
There was a problem hiding this comment.
You'll want to add this around line 59, currently it doesn't do anything.
There was a problem hiding this comment.
Ah I see, so you can't show an alert from a service worker, but you can from a page, hence the postMessage business..
I'll also add instructions to the test survey to select the 'Display an alert' reaction setting then.
anitawoodruff
force-pushed
the
console-log-reply
branch
from
1512649
to
5762f80
Compare
beverloo
reviewed
Jun 1, 2018
| @@ -54,6 +54,9 @@ self.addEventListener('notificationclick', function(event) { | |||
| var message = 'Clicked on "' + notification.title + '"'; | |||
| if (event.action) | |||
| message += ' (action "' + event.action + '")'; | |||
| if (event.reply) { | |||
There was a problem hiding this comment.
Should we allow distinguishing between NULL and the empty string? Could do something like:
if (event.action) {
message += ' (action: "' + event.action + '", reply: ';
message += event.reply === null ? 'null' : '"' + event.reply + '"';
message += ')';
}There was a problem hiding this comment.
this does mean we will get "reply: undefined" when experimental-web-platform-features are disabled atm, but maybe that's okay?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.