Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bevry/getmac#2 #7

Closed
wants to merge 3 commits into from
Closed

fix bevry/getmac#2 #7

wants to merge 3 commits into from

Conversation

caasi
Copy link
Contributor

@caasi caasi commented Sep 27, 2014

@balupton
Copy link
Member

Seems there is a spacing issue with these commits... as every line has changed in the modified files.

@balupton
Copy link
Member

remove 00:00:00:00:00:00 checks

Why do we want this?

@StephenBrown2
Copy link
Contributor

@balupton Whitespace changes are an issue, but to see the diff without them, you can add '?w=1' to the diff view like this

@caasi Seconded @balupton 's question, adding the 00 checks was part of resolving #1 , reverting that change will make the system test work with Travis, but are fairly necessary otherwise.

Also, this would need to be updated for the 'ip link' output I added, as the first column is just an index number.

@caasi
Copy link
Contributor Author

caasi commented Mar 13, 2015

@balupton @StephenBrown2 Sorry about the whitespace changes.

@StephenBrown2 I will check if I can merge it to the HEAD in a day or two. I can not access to my Windows machine right now.

balupton added a commit that referenced this pull request May 10, 2016
@balupton
Copy link
Member

Continuing over at https://github.com/bevry/getmac/compare/caasi-master

@balupton
Copy link
Member

This got paused for personal delays. Added back to my workload.

@mikeumus mikeumus added the enhancement Improvement or suggestion label Sep 20, 2016
@caasi
Copy link
Contributor Author

caasi commented Jul 30, 2017

Try to fix #2 by filtering input with interface name and close this issue for now.

@caasi caasi closed this Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to specify the network adapter we want to fetch the mac for
4 participants