-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Support calculating normals for indexed meshes" (#12716) and …
…add support for calculating smooth normals (#13333) # Objective - Refactor the changes merged in #11654 to compute flat normals for indexed meshes instead of smooth normals. - Fixes #12716 ## Solution - Partially revert the changes in #11654 to compute flat normals for both indexed and unindexed meshes in `compute_flat_normals` - Create a new method, `compute_smooth_normals`, that computes smooth normals for indexed meshes - Create a new method, `compute_normals`, that computes smooth normals for indexed meshes and flat normals for unindexed meshes by default. Use this new method instead of `compute_flat_normals`. ## Testing - Run the example with and without the changes to ensure that the results are identical.
- Loading branch information
1 parent
1efa578
commit 65e62ba
Showing
1 changed file
with
122 additions
and
46 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters