Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wgpu_pass method to TrackedRenderPass #10722

Merged
merged 3 commits into from Nov 25, 2023
Merged

Add wgpu_pass method to TrackedRenderPass #10722

merged 3 commits into from Nov 25, 2023

Conversation

wgxer
Copy link
Contributor

@wgxer wgxer commented Nov 24, 2023

Objective

Solution

  • Add a method to obtain RenderPass to TrackedRenderPass simillar to RenderDevice::wgpu_device

Changelog

Added wgpu_pass method to TrackedRenderPass

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use labels Nov 24, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 24, 2023
@wgxer
Copy link
Contributor Author

wgxer commented Nov 24, 2023 •
edited

I just noticed wgpu_pass method is useless normally without returning mutable reference to RenderPass.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 25, 2023
Merged via the queue into bevyengine:main with commit 4eafd60 Nov 25, 2023
22 checks passed
@NthTensor NthTensor mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JMS55 JMS55 JMS55 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a way to obtain wgpu RenderPass
3 participants
@wgxer @alice-i-cecile @JMS55