Renamed Accessibility plugin to AccessKitPlugin in bevy_winit #10914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed bevy::a11y::AccessibilityPlugin to bevy::a11y::A11YAccessibilityPlugin. - Renamed bevy::winit::accessibility::AccessibilityPlugin to bevy::winit::accessibility::WinitAccessibilityPlugin.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
ItsDoot
added
the
C-Code-Quality
MrGVSV
reviewed
Dec 9, 2023
Nilirad
reviewed
Dec 9, 2023
bogdiw
changed the title
bogdiw
changed the title
Nilirad
approved these changes
Dec 9, 2023
alice-i-cecile
approved these changes
Dec 9, 2023
alice-i-cecile
changed the title
alice-i-cecile
added
S-Ready-For-Final-Review
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
|
Added a migration guide and updated the title for you <3 Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
AccessibilityPlugin#10901Solution
bevy::a11y::AccessibilityPluginremains unchanged.bevy::winit::accessibility::AccessibilityPlugintobevy::winit::accessibility::AccessKitPlugin.Migration Guide
bevy_winit::AccessibilityPluginhas been renamed toAccessKitPlugin.