Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: AnimationPlayer::play doesn't have transition_duration arg #10970

Merged
merged 1 commit into from Dec 13, 2023

Conversation

softmoth
Copy link
Contributor

Objective

The documentation for AnimationPlayer::play mentions a non-existent transition_duration argument from an old iteration of the API. It's confusing.

Solution

Remove the offending sentence.

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as trivial. Thank you!

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Audio Sounds playback and modification S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 13, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 13, 2023
Merged via the queue into bevyengine:main with commit 1ab0f28 Dec 13, 2023
26 checks passed
@softmoth softmoth deleted the anim_play_doc branch December 13, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Audio Sounds playback and modification C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants