Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Gizmos crash due to the persistence policy being set to Unload. Change it to Keep #11192

Merged
merged 1 commit into from Jan 3, 2024
Merged

Fix: Gizmos crash due to the persistence policy being set to Unload. Change it to Keep #11192

merged 1 commit into from Jan 3, 2024

Conversation

fantasyRqg
Copy link
Contributor

Objective

Fixes Gizmos crash due to the persistence policy being set to Unload

Solution

Change it to Keep

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@fantasyRqg fantasyRqg mentioned this pull request Jan 3, 2024
Merged
JMS55
JMS55 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@JMS55 JMS55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, must have missed this, thanks. Shame it doesn't work for gizmos, it feels like bevy_gizmos should maybe be changed. But it doesn't really matter as either way it's getting cleared every frame, and this is an easy fix.

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jan 3, 2024
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 3, 2024
@mockersf mockersf added this pull request to the merge queue Jan 3, 2024
Merged via the queue into bevyengine:main with commit 07cd955 Jan 3, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@JMS55 JMS55 JMS55 approved these changes

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fantasyRqg @mockersf @JMS55