Make sure tracy deps conform to compatibility table #11331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Torstein Grindvik <torstein.grindvik@muybridge.com>
|
Would it be even better to use |
alice-i-cecile
approved these changes
Jan 13, 2024
alice-i-cecile
added
C-Dependencies
mockersf
approved these changes
Jan 14, 2024
I prefer to not use strict versioning and allow semver updates |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 27, 2024
# Objective #11331 move the tracy dependency, this remove the line number to avoid keeping the link in sync --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective bevyengine#11331 move the tracy dependency, this remove the line number to avoid keeping the link in sync --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The table here shows which versions of Tracy should be used combined with which Rust deps.
Reading
bevy_log'sCargo.tomlcan be slightly confusing since the exact versions are not picked from the same row.Reading the produced
Cargo.lockwhen building a Bevy example shows that it's the most recent row that is resolved, but this should be more clearly understood without needing to check the lock file.Solution