Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link to tracy #11521

Merged
merged 4 commits into from
Jan 27, 2024
Merged

fix link to tracy #11521

merged 4 commits into from
Jan 27, 2024

Conversation

ameknite
Copy link
Contributor

@ameknite ameknite commented Jan 25, 2024 •
edited
Loading

Objective

#11331 move the tracy dependency, this remove the line number to avoid keeping the link in sync

alice-i-cecile
alice-i-cecile reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably keep pointing to latest by default in our docs 🤔

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Diagnostics Logging, crash handling, error reporting and performance analysis labels Jan 25, 2024
@ameknite
Copy link
Contributor Author

Ok, if we keep it in latest, this should be merge after 0.13

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jan 25, 2024
@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 25, 2024
@hymm
Copy link
Contributor

hymm commented Jan 26, 2024

We probably should remove the line number rather than trying to keep it in sync.

alice-i-cecile
alice-i-cecile reviewed Jan 26, 2024
View reviewed changes
docs/profiling.md Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, let's remove the line number and merge this now.

@alice-i-cecile alice-i-cecile removed S-Blocked This cannot move forward until something else changes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 26, 2024
@ameknite @alice-i-cecile
Update docs/profiling.md
82ecc3d 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 27, 2024
@alice-i-cecile alice-i-cecile removed this from the 0.14 milestone Jan 27, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 27, 2024
Merged via the queue into bevyengine:main with commit 56c3079 Jan 27, 2024
23 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@ameknite @alice-i-cecile @tjamaan
fix link to tracy (bevyengine#11521)
89504c9 
# Objective

bevyengine#11331 move the tracy dependency, this remove the line number to avoid
keeping the link in sync

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ameknite @hymm @alice-i-cecile