Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meshlet prep #11442

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Meshlet prep #11442

merged 3 commits into from
Jan 22, 2024

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jan 20, 2024 •
edited
Loading

Objective

  • Prep for Meshlet rendering (initial feature) #10164
  • Make deferred_lighting_pass_id a ColorAttachment
  • Correctly extract shadow view frusta so that the view uniforms get populated
  • Make some needed things public
  • Misc formatting

@JMS55 JMS55 added C-Enhancement A new feature A-Rendering Drawing game state to the screen labels Jan 20, 2024
@JMS55 JMS55 requested a review from IceSentry January 20, 2024 20:32
atlv24
atlv24 approved these changes Jan 20, 2024
View reviewed changes
crates/bevy_core_pipeline/src/deferred/node.rs
ops: Operations {
load: LoadOp::Load,
ops: bevy_render::render_resource::Operations {
load: bevy_render::render_resource::LoadOp::Load,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why qualify instead of import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import would be unused on non wasm platforms and give a warning.

@pcwalton
Copy link
Contributor

Seems good to me.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 22, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 22, 2024
Merged via the queue into bevyengine:main with commit a796d53 Jan 22, 2024
23 checks passed
@atlv24 atlv24 mentioned this pull request Mar 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 6, 2024
@atlv24
Fix directional light shadow frustum culling near clip plane to infin…
13d37c5 
…ity (#12342)

# Objective

- Fix slightly wrong logic from #11442
- Directional lights should not have a near clip plane

## Solution

- Push near clip out to infinity, so that the frustum normal is still
available if its needed for whatever reason in shader
- also opportunistically nabs a typo
mockersf pushed a commit that referenced this pull request Mar 8, 2024
@atlv24 @mockersf
Fix directional light shadow frustum culling near clip plane to infin…
2683dfe 
…ity (#12342)

# Objective

- Fix slightly wrong logic from #11442
- Directional lights should not have a near clip plane

## Solution

- Push near clip out to infinity, so that the frustum normal is still
available if its needed for whatever reason in shader
- also opportunistically nabs a typo
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@atlv24 @spectria-limina
Fix directional light shadow frustum culling near clip plane to infin…
72fc7da 
…ity (bevyengine#12342)

# Objective

- Fix slightly wrong logic from bevyengine#11442
- Directional lights should not have a near clip plane

## Solution

- Push near clip out to infinity, so that the frustum normal is still
available if its needed for whatever reason in shader
- also opportunistically nabs a typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlv24 atlv24 atlv24 approved these changes

@IceSentry IceSentry Awaiting requested review from IceSentry

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JMS55 @pcwalton @atlv24 @alice-i-cecile