simplify animated_material example #11576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Build-System
|
I'd like to unbreak CI, but we should make a stress-test version of this to deliberately expose the performance issues that motivated its creation. |
|
this was not a stress test. examples should focus on one thing only |
|
I agree. I'm fine to merge this as is. I'll make an issue to stress-testify this. |
alice-i-cecile
approved these changes
Jan 28, 2024
atlv24
suggested changes
Jan 28, 2024
Comment on lines
+32
to
+34
| let cube = meshes.add(shape::Cube { size: 0.5 }); | ||
| for x in -1..2 { | ||
| for z in -1..2 { |
There was a problem hiding this comment.
if the materials aren't unique there's no point in spawning more than one helmet
There was a problem hiding this comment.
just realized this isnt helmets anymore
|
I'll make a PR to add this back as a stress test |
atlv24
approved these changes
Jan 28, 2024
Comment on lines
+32
to
+34
| let cube = meshes.add(shape::Cube { size: 0.5 }); | ||
| for x in -1..2 { | ||
| for z in -1..2 { |
There was a problem hiding this comment.
just realized this isnt helmets anymore
alice-i-cecile
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective - example `animated_material` is more complex that needed to show how to animate materials - it makes CI crash because it uses too much memory ## Solution - Simplify the example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
animated_materialis more complex that needed to show how to animate materialsSolution