Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added formats to MeshVertexAttribute constant's docstrings #11705

Conversation

ibotha
Copy link
Contributor

@ibotha ibotha commented Feb 4, 2024

Objective

Fixes #11653

Solution

  • Just added the formats to the docstring, I played around with having the format appear in the type somehow so that it didn't need to be written manually in the docstring but it ended up being more trouble than it was worth.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@ibotha
Copy link
Contributor Author

ibotha commented Feb 4, 2024

There seems to be a failing build but I don't think it is related, it seems to be because of the same thing causing #11702

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Feb 4, 2024
@james7132 james7132 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into bevyengine:main with commit dd15890 Feb 5, 2024
23 checks passed
lynn-lumen pushed a commit to lynn-lumen/bevy that referenced this pull request Feb 5, 2024
…ine#11705)

# Objective

Fixes bevyengine#11653 

## Solution

- Just added the formats to the docstring, I played around with having
the format appear in the type somehow so that it didn't need to be
written manually in the docstring but it ended up being more trouble
than it was worth.

Co-authored-by: James Liu <contact@jamessliu.com>
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
…ine#11705)

# Objective

Fixes bevyengine#11653 

## Solution

- Just added the formats to the docstring, I played around with having
the format appear in the type somehow so that it didn't need to be
written manually in the docstring but it ended up being more trouble
than it was worth.

Co-authored-by: James Liu <contact@jamessliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh's MeshVertexAttribute constants should describe the required VertexAttributeValues enum variant
3 participants