Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bevy_render: use the non-send marker from bevy_core #11725

Merged
merged 2 commits into from
Feb 6, 2024
Merged

bevy_render: use the non-send marker from bevy_core #11725

merged 2 commits into from
Feb 6, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 5, 2024

Objective

Solution

  • Use the marker type from bevy_core in bevy_render

Migration Guide

  • If you were using bevy::render::view::NonSendMarker or bevy::render::view::window::NonSendMarker, use bevy::core::NonSendMarker instead

@mockersf mockersf added C-Code-Quality A section of code that is hard to understand or change C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide labels Feb 5, 2024
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2024
@james7132 james7132 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into bevyengine:main with commit 9180be8 Feb 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @hymm @james7132 @alice-i-cecile