Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ahash to 0.8.7 #11785

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Update ahash to 0.8.7 #11785

merged 1 commit into from
Feb 10, 2024

Conversation

SpecificProtagonist
Copy link
Contributor

Objective

bevy_utils only requires aHash 0.8.3, which is broken on Rust 1.7.6:

error: could not compile `ahash` (lib) due to 1 previous error
error[E0635]: unknown feature `stdsimd`

See tkaitchuck/aHash#200

This is fixed in aHash 0.8.7, so require at least that version (Cargo.lock is already up to date).

@Kanabenki Kanabenki added C-Dependencies A change to the crates that Bevy depends on A-Utils Utility functions and types labels Feb 9, 2024
BD103
BD103 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can ignore the check-bans CI failure, since ahash is not the causing it.

@james7132 james7132 added this pull request to the merge queue Feb 10, 2024
Merged via the queue into bevyengine:main with commit 55ada61 Feb 10, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@doonv doonv doonv approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Utils Utility functions and types C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SpecificProtagonist @james7132 @doonv @BD103 @Kanabenki