Support optional clear color in ColorAttachment. #11884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
james-j-obrien
approved these changes
Feb 15, 2024
This represents when the user has configured `ClearColorConfig::None` in their application. If the clear color is `None`, we will always `Load` instead of attempting to clear the attachment on the first call. Fixes bevyengine#11883.
tychedelia
force-pushed
the
11883-clear-color-config
branch
from
c6a9496
to
6143452
Compare
alice-i-cecile
approved these changes
Feb 15, 2024
mockersf
approved these changes
Feb 16, 2024
mockersf
added
C-Bug
doonv
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents when the user has configured
ClearColorConfig::Nonein their application. If the clear color isNone, we will alwaysLoadinstead of attempting to clear the attachment on the first call.Fixes #11883.