Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl ShaderType for LinearRgba #12137

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Impl ShaderType for LinearRgba #12137

merged 4 commits into from
Feb 26, 2024

Conversation

IceSentry
Copy link
Contributor

Objective

  • LinearRgba is the color type intended for shaders but using it for shaders is currently not easy because it doesn't implement ShaderType

Solution

  • add encase as a dependency and impl the required traits.

@IceSentry IceSentry added the A-Rendering Drawing game state to the screen label Feb 26, 2024
@IceSentry IceSentry mentioned this pull request Feb 26, 2024
Merged
bushrat011899
bushrat011899 approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, just a minor suggestion around including the glam feature.

crates/bevy_color/Cargo.toml Outdated Show resolved Hide resolved
alice-i-cecile
alice-i-cecile approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading over https://docs.rs/encase/latest/encase/trait.ShaderType.html and https://gpuweb.github.io/gpuweb/wgsl/#host-shareable-types, I'm happy with this set of changes.

@alice-i-cecile @bushrat011899
Don't pull in a glam dep
edefde0 
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 26, 2024
@alice-i-cecile alice-i-cecile added the C-Usability A simple quality-of-life change that makes Bevy easier to use label Feb 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 26, 2024
Merged via the queue into bevyengine:main with commit abc6f98 Feb 26, 2024
30 of 31 checks passed
msvbg pushed a commit to msvbg/bevy that referenced this pull request Feb 27, 2024
@IceSentry @alice-i-cecile
@bushrat011899 @msvbg
Impl ShaderType for LinearRgba (bevyengine#12137)
c3f937d 
# Objective

- LinearRgba is the color type intended for shaders but using it for
shaders is currently not easy because it doesn't implement ShaderType

## Solution

- add encase as a dependency and impl the required traits.

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Co-authored-by: Zachary Harrold <zac@harrold.com.au>
@msvbg msvbg mentioned this pull request Feb 27, 2024
Merged
@IceSentry IceSentry deleted the linear-rgba-shader-type branch April 4, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@viridia viridia viridia approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@atlv24 atlv24 atlv24 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IceSentry @viridia @bushrat011899 @alice-i-cecile @atlv24