New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support wireframes for 2D meshes #12135
Conversation
The generated |
The generated |
The generated |
The example looks very different for me. I'm only seeing lines around the shapes but no inside triangles are visible for me |
Also, can you rebase on main? I think the Color changes will break some stuff |
The generated |
c188f70
to
b1f265e
Compare
Not entirely sure why the |
Yep, the |
I see that @IceSentry approved already, but I felt that I should use the new color types now that #12137 was merged. I added 80aea41 and 2d177ff. |
I think adding it to bevy_internal should be done in a separate PR. I know it's tiny, but it makes it easier to keep track of history if it isn't mixed with unrelated things. I'm not entirely sure what the plan is for migration of bevy_color though. |
Agreed. I'd like a small PR adding it to |
I've added the new color types to |
Rebased on top of #12158. |
This should fix #5881 |
Oh, didn't realize we had two of these PRs. My bad for not searching properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, and an important feature.
@msvbg looks like there's been breaking changes on |
I'll get it fixed up. |
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
@alice-i-cecile I resolved the problems in 7451663 and checked that the example still looks good :) |
Objective
Wireframes are currently supported for 3D meshes using the
WireframePlugin
inbevy_pbr
. This PR adds the same functionality for 2D meshes.Closes #5881.
Solution
Since there's no easy way to share material implementations between 2D, 3D, and UI, this is mostly a straight copy and rename from the original plugin into
bevy_sprite
.Changelog
Wireframe2dPlugin
and related types to support 2D wireframes.