many_cubes: Add no automatic batching and generation of different meshes #12363
Conversation
superdump
added
A-Rendering
examples/stress_tests/many_cubes.rs
Outdated
| std::iter::repeat_with(|| { | ||
| let radius = radius_rng.gen_range(0.25f32..=0.75f32); | ||
| let (handle, transform) = match variant % 15 { | ||
| 0 => ( |
There was a problem hiding this comment.
Wouldn't you want to only vary the uniqueness of the mesh and not the overall triangle count? Couldn't you use a bunch of separate instances of same-size cubes?
There was a problem hiding this comment.
I could, but I'd like to use a variety of meshes as well. As they are randomly distributed, the per-frame draws should be fairly consistent, if that's what you're concerned about?
There was a problem hiding this comment.
The concern is mainly "changing more than one variable in an experiment."
This switch adds a bunch of triangles to the scene, in addition to making the mesh assets unique. So it seems like like comparisons between runs where this switch is enabled and not enabled would not be useful.
I had assumed based on (from PR description):
This breaks batches based on different meshes.
That just making the assets unique was the main goal.
If that's not the case or not a worry, then I guess I'm not bothered.
There was a problem hiding this comment.
My goal was not really to compare single mesh vs many meshes, rather just to create a scene with a bunch of different meshes. The benchmarking is done by using the same configuration of the stress test with two versions of the code.
superdump
force-pushed
the
many_cubes-shadows-no_auto_batching-meshes-orientations
branch
from
5043487
to
49a00bc
Compare
| } | ||
|
|
||
| // camera | ||
| commands.spawn(Camera3dBundle::default()); | ||
| // Inside-out box around the meshes onto which shadows are cast (though you cannot see them...) | ||
| commands.spawn(( |
There was a problem hiding this comment.
I'm not sure I understand what this does.
There was a problem hiding this comment.
It spawns a box that all the other cubes fit within. It was meant to be just a surface for the cubes to cast shadows on. But because of the camera position, the shadows don’t seem to be visible, as far as I can tell.
james7132
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Co-authored-by: François Mockers <francois.mockers@vleue.com>
…hes (bevyengine#12363) # Objective - Enable stressing of more of the material mesh entity draw code paths ## Solution - Support generation of a number of different mesh assets from the built-in primitives, and select randomly from them. This breaks batches based on different meshes. - Support disabling automatic batching. This skips the batching cost at the expense of stressing render pass draw command encoding. - Support enabling directional light cascaded shadow mapping - this is commonly a big source of slow down in normal scenes. --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: François Mockers <francois.mockers@vleue.com>
Objective
Solution