Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't examine every entity when extracting SpriteSources. #12957

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Don't examine every entity when extracting SpriteSources. #12957

merged 1 commit into from
Apr 13, 2024

Commits on Apr 13, 2024

  1. Don't examine every entity when extracting SpriteSources. 

    `ExtractComponentPlugin` doesn't check to make sure the component is
actually present unless it's in the `QueryFilter`. This meant we placed
it everywhere. This regressed performance on many examples, such as
`many_cubes`.

Fixes bevyengine#12956.
    @pcwalton
    pcwalton committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    6260011 View commit details
    Browse the repository at this point in the history