Add paragraph on requesting reviews #13161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Docs
|
@MalekiRe can I get your review here? /meta |
NiseVoid
approved these changes
May 1, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
This might be better in a separate pr, but should there be a bit about going on discord to beg for reviews in the relevant discord channel? I'm a little hesitant to direct people to discord in an official document, but this would just be documenting what is probably the most effective way of getting something reviewed currently. |
Jondolf
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Requesting reviews is a useful tool for improving discoverability of PRs that contributors might be interested in and capable of reviewing.
However, many Bevy org members and authors aren't aware that they can and should request reviews.
Solution
Actually document that this is good practice, and remind people that it's just a nudge.